From: David Miller <davem@davemloft.net>
To: mkubecek@suse.cz
Cc: hannes@stressinduktion.org, netdev@vger.kernel.org,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net
Subject: Re: [PATCH net] ipv6: do not overwrite inetpeer metrics prematurely
Date: Wed, 12 Mar 2014 16:54:43 -0400 (EDT) [thread overview]
Message-ID: <20140312.165443.1358759725438654072.davem@davemloft.net> (raw)
In-Reply-To: <20140311150814.GB3287@unicorn.suse.cz>
From: Michal Kubecek <mkubecek@suse.cz>
Date: Tue, 11 Mar 2014 16:08:14 +0100
> + nla_for_each_attr(nla, mx, mx_len, remaining) {
> + int type = nla_type(nla);
> +
> + if (type) {
> + if (type > RTAX_MAX)
> + return -EINVAL;
> +
> + mp[type - 1] = nla_get_u32(nla);
> + }
> + }
It was surprising to me that nla_for_each_attr() works with a second
argument of NULL.
It only does so when the length is zero, due to how the test in nla_ok()
is codified.
I know it's a minor nit, but can you only execute this loop if mx is
non-NULL?
Perhaps you can put this into (yet another) helper function:
int __fib6_commit_metrics(u32 *mp, struct nlattr *mx, int mx_len)
Otherwise looks good to me.
prev parent reply other threads:[~2014-03-12 20:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 9:50 [PATCH net] ipv6: do not overwrite inetpeer metrics prematurely Michal Kubecek
2014-03-06 19:24 ` David Miller
2014-03-06 20:06 ` Michal Kubecek
2014-03-07 12:36 ` [PATCH net v2] " Michal Kubecek
2014-03-07 20:52 ` [PATCH net] " David Miller
2014-03-07 21:38 ` Michal Kubecek
2014-03-08 8:34 ` Hannes Frederic Sowa
2014-03-08 8:06 ` Hannes Frederic Sowa
2014-03-10 0:26 ` David Miller
2014-03-10 0:52 ` Hannes Frederic Sowa
2014-03-10 5:03 ` David Miller
2014-03-10 8:15 ` Michal Kubecek
2014-03-10 12:00 ` Hannes Frederic Sowa
2014-03-10 13:15 ` Michal Kubecek
2014-03-11 2:38 ` David Miller
2014-03-11 9:53 ` Michal Kubecek
2014-03-11 15:08 ` Michal Kubecek
2014-03-11 15:20 ` Hannes Frederic Sowa
2014-03-11 15:39 ` Michal Kubecek
2014-03-25 19:11 ` Hannes Frederic Sowa
2014-03-26 15:09 ` Michal Kubecek
2014-03-26 15:42 ` [PATCH net-next v3] " Michal Kubecek
2014-03-26 15:50 ` Hannes Frederic Sowa
2014-03-26 15:56 ` Michal Kubecek
2014-03-26 16:05 ` [PATCH net-next v4] " Michal Kubecek
2014-03-27 5:06 ` Hannes Frederic Sowa
2014-03-27 7:43 ` Michal Kubecek
2014-03-27 12:04 ` [PATCH net-next v5] " Michal Kubecek
2014-03-27 16:30 ` Hannes Frederic Sowa
2014-03-27 19:09 ` David Miller
2014-03-12 20:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312.165443.1358759725438654072.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).