From mboxrd@z Thu Jan 1 00:00:00 1970 From: Veaceslav Falico Subject: Re: [PATCH net-next 0/3] bonding: support 802.1ad vlan protocol Date: Wed, 12 Mar 2014 07:13:53 +0100 Message-ID: <20140312061353.GA2924@redhat.com> References: <1394509422-8704-1-git-send-email-dingtianhong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: fubar@us.ibm.com, andy@greyhouse.net, kaber@trash.net, davem@davemloft.net, netdev@vger.kernel.org To: Ding Tianhong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14902 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbaCLGOO (ORCPT ); Wed, 12 Mar 2014 02:14:14 -0400 Content-Disposition: inline In-Reply-To: <1394509422-8704-1-git-send-email-dingtianhong@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Mar 11, 2014 at 11:43:39AM +0800, Ding Tianhong wrote: >The bonding could only use vlan proto 802.1q regardless the vlan dev is >802.1ad or 802.1q, so add new interface to get vlan proto by vlan dev and >use it to send packages by correct vlan protocol. It's not that easy. 802.1ad packets should be double-tagged, however you're just changing the protocol (from 1q to 1ad) and tagging just once. Have you actually tested this patchset, does it produce correct QinQ packets? > >Ding Tianhong (3): > vlan: make a new function vlan_dev_vlan_proto() and export > bonding: support different vlan proto for bond_arp_send() > bonding: choose the correct vlan proto for alb_send_learning_packets > > drivers/net/bonding/bond_alb.c | 7 ++++--- > drivers/net/bonding/bond_main.c | 23 +++++++++++++++-------- > include/linux/if_vlan.h | 7 +++++++ > net/8021q/vlan_core.c | 6 ++++++ > 4 files changed, 32 insertions(+), 11 deletions(-) > >-- >1.8.0 > >