netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Christian Riesch <christian.riesch@omicron.at>
Cc: "Sørensen," <Stefan.Sorensen@spectralink.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bhutchings@solarflare.com, davem@davemloft.net
Subject: Re: [PATCH RFC net-next v1 0/9] ptp: dynamic pin control
Date: Wed, 12 Mar 2014 15:22:48 +0100	[thread overview]
Message-ID: <20140312142248.GA10256@netboy> (raw)
In-Reply-To: <E9E8485F5E84770575AD1FAB@[172.22.2.41]>

On Wed, Mar 12, 2014 at 07:58:37AM +0100, Christian Riesch wrote:
> >I did not change the n_per_out in this series,
> 
> Why not? I think it would be a good idea to set both n_ext_ts and
> n_per_out to the correct value right from the start (8, right?).
> Christian

Yes, it is a good idea, but it is a little extra work, especially
testing it. Channels 0 and 1 must be programmed differently, IIRC.

Right now, I am focusing on:

1. getting the new ioctl interface right
2. making it work for the phyter while keeping the module params.

After that, as I said before:
 
> >but once this basic
> >support gets merged, then you will be able to increase n_per_out for
> >the dp83640 with little extra effort.

Thanks,
Richard

  reply	other threads:[~2014-03-12 14:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-08 19:42 [PATCH RFC net-next v1 0/9] ptp: dynamic pin control Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 1/9] ptp: introduce programmable pins Richard Cochran
2014-03-10 12:53   ` Sørensen, Stefan
2014-03-10 13:32     ` Richard Cochran
2014-03-11  7:58   ` Christian Riesch
2014-03-11 10:08     ` Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 2/9] ptp: add the pin GET/SETFUNC ioctls to the testptp program Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 3/9] ptp: expose the programmable pins via sysfs Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 4/9] ptp: drivers: set the number of programmable pins Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 5/9] dp83640: trivial fixes Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 6/9] dp83640: correct the periodic output frequency Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 7/9] dp83640: implement programmable pin functions Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 8/9] dp83640: let external input pins from the module parameters be defaults Richard Cochran
2014-03-08 19:42 ` [PATCH RFC net-next v1 9/9] dp83640: let the periodic pin from the module parameter be a default Richard Cochran
2014-03-10 12:52 ` [PATCH RFC net-next v1 0/9] ptp: dynamic pin control Sørensen, Stefan
2014-03-10 13:42   ` Richard Cochran
2014-03-12  6:58     ` Christian Riesch
2014-03-12 14:22       ` Richard Cochran [this message]
2014-03-10 14:05   ` Richard Cochran
2014-03-12  8:21 ` Christian Riesch
2014-03-12 14:46   ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312142248.GA10256@netboy \
    --to=richardcochran@gmail.com \
    --cc=Stefan.Sorensen@spectralink.com \
    --cc=bhutchings@solarflare.com \
    --cc=christian.riesch@omicron.at \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).