From: David Miller <davem@davemloft.net>
To: stefan.wahren@i2se.com
Cc: fugang.duan@freescale.com, lznuaa@gmail.com, festevam@gmail.com,
netdev@vger.kernel.org, shawn.guo@linaro.org,
Fabio.Estevam@freescale.com, Frank.Li@freescale.com,
kernel@pengutronix.de
Subject: Re: [PATCH net resend] eth: fec: Fix lost promiscuous mode after reconnecting cable
Date: Thu, 13 Mar 2014 15:46:37 -0400 (EDT) [thread overview]
Message-ID: <20140313.154637.2019326790014536724.davem@davemloft.net> (raw)
In-Reply-To: <1394620099-4509-1-git-send-email-stefan.wahren@i2se.com>
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Wed, 12 Mar 2014 11:28:19 +0100
> If the Freescale fec is in promiscuous mode and network cable is
> reconnected then the promiscuous mode get lost. The problem is caused
> by a too soon call of set_multicast_list to re-enable promisc mode.
> The FEC_R_CNTRL register changes are overwritten by fec_restart.
>
> This patch fixes this by moving the call behind the init of FEC_R_CNTRL
> register in fec_restart.
>
> Successful tested on a i.MX28 board.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied, thank you.
prev parent reply other threads:[~2014-03-13 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 9:29 [Bug] net/fec on i.MX28: promiscuous mode lost after reconnecting network cable Stefan Wahren
2014-03-06 10:30 ` Fabio Estevam
2014-03-06 17:43 ` Frank Li
2014-03-07 2:10 ` fugang.duan
2014-03-07 16:00 ` Stefan Wahren
2014-03-08 1:35 ` Fabio Estevam
2014-03-10 18:18 ` [PATCH net] eth: fec: Fix lost promiscuous mode after reconnecting cable Stefan Wahren
2014-03-11 1:28 ` fugang.duan
2014-03-12 2:48 ` David Miller
2014-03-12 10:28 ` [PATCH net resend] " Stefan Wahren
2014-03-13 19:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313.154637.2019326790014536724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Fabio.Estevam@freescale.com \
--cc=Frank.Li@freescale.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@freescale.com \
--cc=kernel@pengutronix.de \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).