* next-20140313 - build error in e1000e driver
@ 2014-03-13 19:32 Valdis Kletnieks
2014-03-13 23:01 ` Jeff Kirsher
2014-03-14 8:33 ` Mika Westerberg
0 siblings, 2 replies; 3+ messages in thread
From: Valdis Kletnieks @ 2014-03-13 19:32 UTC (permalink / raw)
To: Mika Westerberg; +Cc: e1000-devel, netdev, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1543 bytes --]
My kernel has CONFIG_PM_SLEEP=n, which leads to hilarity...
CC drivers/net/ethernet/intel/e1000e/netdev.o
drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' undeclared here (not in a function)
.suspend = e1000e_pm_suspend,
^
drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' undeclared here (not in a function)
.resume = e1000e_pm_resume,
^
make[5]: *** [drivers/net/ethernet/intel/e1000e/netdev.o] Error 1
make[4]: *** [drivers/net/ethernet/intel/e1000e] Error 2
make[3]: *** [drivers/net/ethernet/intel] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Commit 38a529b5d4 claims to fix a related issue, but doesn't seem to do so correctly.
Author: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Thu Jan 16 14:39:39 2014 +0200
e1000e: Fix compilation warning when !CONFIG_PM_SLEEP
Commit 7509963c703b (e1000e: Fix a compile flag mis-match for
suspend/resume) moved suspend and resume hooks to be available when
CONFIG_PM is set. However, it can be set even if CONFIG_PM_SLEEP is not set
causing following warnings to be emitted:
drivers/net/ethernet/intel/e1000e/netdev.c:6178:12: warning:
‘e1000_suspend’ defined but not used [-Wunused-function]
drivers/net/ethernet/intel/e1000e/netdev.c:6185:12: warning:
‘e1000_resume’ defined but not used [-Wunused-function]
[-- Attachment #1.2: Type: application/pgp-signature, Size: 848 bytes --]
[-- Attachment #2: Type: text/plain, Size: 370 bytes --]
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
[-- Attachment #3: Type: text/plain, Size: 257 bytes --]
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-20140313 - build error in e1000e driver
2014-03-13 19:32 next-20140313 - build error in e1000e driver Valdis Kletnieks
@ 2014-03-13 23:01 ` Jeff Kirsher
2014-03-14 8:33 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2014-03-13 23:01 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: e1000-devel@lists.sourceforge.net, netdev, Mika Westerberg, LKML
On Thu, Mar 13, 2014 at 12:32 PM, Valdis Kletnieks
<Valdis.Kletnieks@vt.edu> wrote:
> My kernel has CONFIG_PM_SLEEP=n, which leads to hilarity...
>
> CC drivers/net/ethernet/intel/e1000e/netdev.o
> drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' undeclared here (not in a function)
> .suspend = e1000e_pm_suspend,
> ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' undeclared here (not in a function)
> .resume = e1000e_pm_resume,
> ^
> make[5]: *** [drivers/net/ethernet/intel/e1000e/netdev.o] Error 1
> make[4]: *** [drivers/net/ethernet/intel/e1000e] Error 2
> make[3]: *** [drivers/net/ethernet/intel] Error 2
> make[2]: *** [drivers/net/ethernet] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> Commit 38a529b5d4 claims to fix a related issue, but doesn't seem to do so correctly.
>
> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> Date: Thu Jan 16 14:39:39 2014 +0200
>
> e1000e: Fix compilation warning when !CONFIG_PM_SLEEP
>
> Commit 7509963c703b (e1000e: Fix a compile flag mis-match for
> suspend/resume) moved suspend and resume hooks to be available when
> CONFIG_PM is set. However, it can be set even if CONFIG_PM_SLEEP is not set
> causing following warnings to be emitted:
>
> drivers/net/ethernet/intel/e1000e/netdev.c:6178:12: warning:
> ‘e1000_suspend’ defined but not used [-Wunused-function]
>
> drivers/net/ethernet/intel/e1000e/netdev.c:6185:12: warning:
> ‘e1000_resume’ defined but not used [-Wunused-function]
>
I believe David Ertman fixed this and David Miller's net-next tree
contains the patch that resolved this.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-20140313 - build error in e1000e driver
2014-03-13 19:32 next-20140313 - build error in e1000e driver Valdis Kletnieks
2014-03-13 23:01 ` Jeff Kirsher
@ 2014-03-14 8:33 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2014-03-14 8:33 UTC (permalink / raw)
To: Valdis Kletnieks; +Cc: e1000-devel, netdev, linux-kernel
On Thu, Mar 13, 2014 at 03:32:48PM -0400, Valdis Kletnieks wrote:
> My kernel has CONFIG_PM_SLEEP=n, which leads to hilarity...
>
> CC drivers/net/ethernet/intel/e1000e/netdev.o
> drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' undeclared here (not in a function)
> .suspend = e1000e_pm_suspend,
> ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' undeclared here (not in a function)
> .resume = e1000e_pm_resume,
> ^
> make[5]: *** [drivers/net/ethernet/intel/e1000e/netdev.o] Error 1
> make[4]: *** [drivers/net/ethernet/intel/e1000e] Error 2
> make[3]: *** [drivers/net/ethernet/intel] Error 2
> make[2]: *** [drivers/net/ethernet] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> Commit 38a529b5d4 claims to fix a related issue, but doesn't seem to do
> so correctly.
It fixes it correctly. The problem is that it got broke again with
the following commit:
d392f8ddb8 e1000e: Refactor PM flows
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-14 8:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-13 19:32 next-20140313 - build error in e1000e driver Valdis Kletnieks
2014-03-13 23:01 ` Jeff Kirsher
2014-03-14 8:33 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).