From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: ebiederm@xmission.com, netdev@vger.kernel.org, gospo@redhat.com,
sassmann@redhat.com, jesse.brandeburg@intel.com,
catherine.sullivan@intel.com
Subject: Re: [net-next] i40evf: Rename i40e_ptype_lookup i40evf_ptype_lookup
Date: Tue, 18 Mar 2014 13:26:43 -0400 (EDT) [thread overview]
Message-ID: <20140318.132643.599932107562895578.davem@davemloft.net> (raw)
In-Reply-To: <1395127610-3290-3-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 18 Mar 2014 00:26:50 -0700
> From: Eric W Biederman <ebiederm@xmission.com>
>
> When compiling the i40e and the i40evf driver into the same kernel I get:
> LD drivers/net/ethernet/intel/built-in.o
> drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x300): multiple definition of `i40e_ptype_lookup'
> drivers/net/ethernet/intel/i40e/built-in.o:(.data+0x780): first defined here
> make[3]: *** [drivers/net/ethernet/intel/built-in.o] Error 1
> make[2]: *** [drivers/net/ethernet/intel] Error 2
> make[1]: *** [drivers/net/ethernet/] Error 2
> make: *** [sub-make] Error 2
>
> Fix this by renaming the i40evf version of this structure from
> i40e_ptype_lookup to i40evf_ptype_lookup.
>
> This build failure was introduced in:
> commit 206812b5fccb808d1194344eaa942f68f59b2630
> Author: Jesse Brandeburg <jesse.brandeburg@intel.com>
> i40e/i40evf: i40e implementation for skb_set_hash
>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Catherine Sullivan <catherine.sullivan@intel.com>
> Signed-off-by: Eric W Biederman <ebiederm@xmission.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2014-03-18 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 7:26 [net-next] i40evf: Rename i40e_ptype_lookup i40evf_ptype_lookup Jeff Kirsher
2014-03-18 17:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318.132643.599932107562895578.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=catherine.sullivan@intel.com \
--cc=ebiederm@xmission.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).