From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: bjorn-yOkvZcmFvRU@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org,
alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
pasik-X3B1VOXEql0@public.gmane.org,
tschaefer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org
Subject: Re: [PATCH net,stable] net: cdc_ncm: fix control message ordering
Date: Tue, 18 Mar 2014 15:58:42 -0400 (EDT) [thread overview]
Message-ID: <20140318.155842.1610081544107118579.davem@davemloft.net> (raw)
In-Reply-To: <1395069918-18585-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
From: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
Date: Mon, 17 Mar 2014 16:25:18 +0100
> This is a context modified revert of commit 6a9612e2cb22
> ("net: cdc_ncm: remove ncm_parm field") which introduced
> a NCM specification violation, causing setup errors for
> some devices. These errors resulted in the device and
> host disagreeing about shared settings, with complete
> failure to communicate as the end result.
>
> The NCM specification require that many of the NCM specific
> control reuests are sent only while the NCM Data Interface
> is in alternate setting 0. Reverting the commit ensures that
> we follow this requirement.
>
> Fixes: 6a9612e2cb22 ("net: cdc_ncm: remove ncm_parm field")
> Reported-and-tested-by: Pasi Kärkkäinen <pasik-X3B1VOXEql0@public.gmane.org>
> Reported-by: Thomas Schäfer <tschaefer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org>
> Signed-off-by: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
> ---
> This needs to go to v3.14 and v3.13.x stable. The bug was introduced
> in v3.13.
Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-18 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 15:25 [PATCH net,stable] net: cdc_ncm: fix control message ordering Bjørn Mork
[not found] ` <1395069918-18585-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2014-03-18 19:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318.155842.1610081544107118579.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=bjorn-yOkvZcmFvRU@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
--cc=pasik-X3B1VOXEql0@public.gmane.org \
--cc=tschaefer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).