From: Thomas Graf <tgraf@suug.ch>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
john.fastabend@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: sched: use no more than one page in struct fw_head
Date: Tue, 18 Mar 2014 09:19:42 +0000 [thread overview]
Message-ID: <20140318091942.GE8956@casper.infradead.org> (raw)
In-Reply-To: <1395112849.9114.17.camel@edumazet-glaptop2.roam.corp.google.com>
On 03/17/14 at 08:20pm, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> In commit b4e9b520ca5d ("[NET_SCHED]: Add mask support to fwmark
> classifier") Patrick added an u32 field in fw_head, making it slightly
> bigger than one page.
>
> Lets use 256 slots to make fw_hash() more straight forward, and move
> @mask to the beginning of the structure as we often use a small number
> of skb->mark. @mask and first hash buckets share the same cache line.
>
> This brings back the memory usage to less than 4000 bytes, and permits
> John to add a rcu_head at the end of the structure later without any
> worry.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Thomas Graf <tgraf@suug.ch>
> Cc: John Fastabend <john.fastabend@gmail.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2014-03-18 9:19 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 17:03 [RCU PATCH 00/14] Remove qdisc lock around ingress Qdisc John Fastabend
2014-03-10 17:03 ` [RCU PATCH 01/14] net: qdisc: use rcu prefix and silence sparse warnings John Fastabend
2014-03-10 17:20 ` Eric Dumazet
2014-03-10 17:04 ` [RCU PATCH 02/14] net: rcu-ify tcf_proto John Fastabend
2014-03-10 17:30 ` Eric Dumazet
2014-03-10 17:04 ` [RCU PATCH 03/14] net: sched: cls_basic use RCU John Fastabend
2014-03-10 17:33 ` Eric Dumazet
2014-03-10 17:04 ` [RCU PATCH 04/14] net: sched: cls_cgroup " John Fastabend
2014-03-10 17:36 ` Eric Dumazet
2014-03-10 17:05 ` [RCU PATCH 05/14] net: sched: cls_flow " John Fastabend
2014-03-10 17:38 ` Eric Dumazet
2014-03-10 17:05 ` [RCU PATCH 06/14] net: sched: fw " John Fastabend
2014-03-10 17:41 ` Eric Dumazet
2014-03-12 16:41 ` John Fastabend
2014-03-12 17:01 ` Eric Dumazet
2014-03-13 20:22 ` Paul E. McKenney
2014-03-13 20:56 ` Eric Dumazet
2014-03-13 21:15 ` Paul E. McKenney
2014-03-14 5:43 ` John Fastabend
2014-03-14 13:28 ` Paul E. McKenney
2014-03-14 13:46 ` Eric Dumazet
2014-03-14 15:38 ` Paul E. McKenney
2014-03-14 18:50 ` Paul E. McKenney
2014-03-14 18:59 ` Paul E. McKenney
2014-03-14 19:55 ` Eric Dumazet
2014-03-14 20:35 ` Paul E. McKenney
2014-03-16 16:06 ` [PATCH net-next] net: sched: use no more than one page in struct fw_head Eric Dumazet
2014-03-17 13:51 ` Thomas Graf
2014-03-17 14:13 ` Eric Dumazet
2014-03-17 14:29 ` David Laight
2014-03-17 15:16 ` Eric Dumazet
2014-03-17 15:30 ` Thomas Graf
2014-03-17 15:33 ` Eric Dumazet
2014-03-17 15:43 ` David Laight
2014-03-17 15:52 ` Eric Dumazet
2014-03-17 15:28 ` Thomas Graf
2014-03-17 15:50 ` Thomas Graf
2014-03-17 16:00 ` David Laight
2014-03-17 16:16 ` Eric Dumazet
2014-03-18 2:31 ` David Miller
2014-03-18 3:02 ` Eric Dumazet
2014-03-18 3:20 ` [PATCH v2 " Eric Dumazet
2014-03-18 9:19 ` Thomas Graf [this message]
2014-03-18 18:18 ` David Miller
2014-03-10 17:06 ` [RCU PATCH 07/14] net: sched: RCU cls_route John Fastabend
2014-03-10 17:45 ` Eric Dumazet
2014-03-10 19:36 ` John Fastabend
2014-03-10 17:06 ` [RCU PATCH 08/14] net: sched: RCU cls_tcindex John Fastabend
2014-03-10 17:07 ` [RCU PATCH 09/14] net: sched: make cls_u32 lockless John Fastabend
2014-03-10 17:58 ` Eric Dumazet
2014-03-10 17:07 ` [RCU PATCH 10/14] net: sched: rcu'ify cls_rsvp John Fastabend
2014-03-10 17:07 ` [RCU PATCH 11/14] net: make cls_bpf rcu safe John Fastabend
2014-03-10 17:08 ` [RCU PATCH 12/14] net: sched: make tc_action safe to walk under RCU John Fastabend
2014-03-10 17:08 ` [RCU PATCH 13/14] net: sched: make bstats per cpu and estimator RCU safe John Fastabend
2014-03-10 18:06 ` Eric Dumazet
2014-03-10 19:36 ` John Fastabend
2014-03-10 17:09 ` [RCU PATCH 14/14] net: sched: drop ingress qdisc lock John Fastabend
2014-03-11 20:36 ` [RCU PATCH 00/14] Remove qdisc lock around ingress Qdisc David Miller
2014-03-11 20:53 ` Eric Dumazet
2014-03-12 6:58 ` Jamal Hadi Salim
2014-03-12 16:45 ` John Fastabend
2014-03-13 8:44 ` Jamal Hadi Salim
2014-03-14 7:28 ` John Fastabend
2014-03-14 7:45 ` Jamal Hadi Salim
2014-03-12 18:25 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318091942.GE8956@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).