From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Markus Pargmann <mpa@pengutronix.de>,
Benedikt Spranger <b.spranger@linutronix.de>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: [patch 12/12] can: c_can: Avoid led toggling for every packet.
Date: Tue, 18 Mar 2014 17:19:15 -0000 [thread overview]
Message-ID: <20140318171127.923041002@linutronix.de> (raw)
In-Reply-To: 20140318171007.528610837@linutronix.de
[-- Attachment #1: can-c_can-move-rx-led-toggle.patch --]
[-- Type: text/plain, Size: 831 bytes --]
There is no point to toggle the RX led for every packet. Especially if
we have a full FIFO we want to avoid everything we can.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/net/can/c_can/c_can.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Index: linux/drivers/net/can/c_can/c_can.c
===================================================================
--- linux.orig/drivers/net/can/c_can/c_can.c
+++ linux/drivers/net/can/c_can/c_can.c
@@ -433,9 +433,6 @@ static int c_can_read_msg_object(struct
stats->rx_packets++;
stats->rx_bytes += frame->can_dlc;
-
- can_led_event(dev, CAN_LED_EVENT_RX);
-
return 0;
}
@@ -892,6 +889,10 @@ static int c_can_do_rx_poll(struct net_d
pkts += n;
quota -= n;
}
+
+ if (pkts)
+ can_led_event(dev, CAN_LED_EVENT_RX);
+
return pkts;
}
next prev parent reply other threads:[~2014-03-18 17:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:19 [patch 00/12] can: c_can: Fix a series of serious bugs and improve the performance Thomas Gleixner
2014-03-18 17:19 ` [patch 02/12] can: c_can: Fix hardware raminit function Thomas Gleixner
2014-03-18 18:38 ` Marc Kleine-Budde
2014-03-18 22:15 ` Thomas Gleixner
2014-03-19 6:37 ` Oliver Hartkopp
2014-03-19 9:22 ` Thomas Gleixner
2014-03-18 17:19 ` [patch 01/12] can: c_can: Wait for CONTROL_INIT to be cleared Thomas Gleixner
2014-03-18 18:11 ` Marc Kleine-Budde
2014-03-18 18:19 ` Thomas Gleixner
2014-03-18 17:19 ` [patch 03/12] can: c_can: Make it SMP safe Thomas Gleixner
2014-03-18 18:46 ` Marc Kleine-Budde
2014-03-18 19:40 ` Thomas Gleixner
2014-03-18 17:19 ` [patch 05/12] can: c_can: Fix the lost message handling Thomas Gleixner
2014-03-18 17:19 ` [patch 04/12] can: c_can: Fix buffer ordering for real Thomas Gleixner
2014-03-18 17:19 ` [patch 06/12] can: c_can: Remove braindamaged EOB exit Thomas Gleixner
2014-03-18 17:19 ` [patch 07/12] can: c_can: Provide protection in the xmit path Thomas Gleixner
2014-03-18 17:19 ` [patch 08/12] can: c_can: Makethe code readable Thomas Gleixner
2014-03-18 17:37 ` Joe Perches
2014-03-18 18:23 ` Thomas Gleixner
2014-03-18 18:27 ` [patch 08/12 V2] " Thomas Gleixner
2014-03-18 17:19 ` [patch 09/12] can: c_can: Reduce register access for real Thomas Gleixner
2014-03-18 17:19 ` [patch 11/12] can: c_can: Simplify TX interrupt cleanup Thomas Gleixner
2014-03-18 17:19 ` [patch 10/12] can: c_can: Store dlc private Thomas Gleixner
2014-03-18 17:19 ` Thomas Gleixner [this message]
2014-03-18 20:18 ` can: c_can: Reduce interrupt load by 50% Thomas Gleixner
2014-03-18 20:35 ` Joe Perches
2014-03-18 20:43 ` Thomas Gleixner
2014-03-18 21:27 ` Joe Perches
2014-03-31 22:35 ` [patch 00/12] can: c_can: Fix a series of serious bugs and improve the performance Thomas Gleixner
2014-04-01 8:09 ` Marc Kleine-Budde
2014-04-01 9:07 ` Thomas Gleixner
2014-04-01 9:09 ` Marc Kleine-Budde
2014-04-01 21:29 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318171127.923041002@linutronix.de \
--to=tglx@linutronix.de \
--cc=b.spranger@linutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mpa@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).