From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: hannes@stressinduktion.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: fix RTNL assert fail in DAD
Date: Wed, 19 Mar 2014 00:17:36 -0400 (EDT) [thread overview]
Message-ID: <20140319.001736.730011705431992209.davem@davemloft.net> (raw)
In-Reply-To: <20140318175406.78339ffe@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 18 Mar 2014 17:54:06 -0700
> On Tue, 18 Mar 2014 01:29:08 +0100
> Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
>
>> I wonder if we should put the whole ipv6_ifa_notify infrastructure in a
>> workqueue? I don't like that either and it could add subtile races.
>
> That is option, might be some call chains that already have rtnl_lock held.
There are TAHI ipv6 conformance tests that expect state changes to be
precisely synchronous.
And frankly it's pretty reasonable to send two packets back to back,
one which causes the state change and one which tests if the state
change happened, and expect that to work.
next prev parent reply other threads:[~2014-03-19 4:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 23:18 [PATCH net] ipv6: fix RTNL assert fail in DAD Stephen Hemminger
2014-03-18 0:29 ` Hannes Frederic Sowa
2014-03-19 0:54 ` Stephen Hemminger
2014-03-19 4:17 ` David Miller [this message]
2014-03-19 6:58 ` Stephen Hemminger
2014-03-19 17:53 ` David Miller
2014-03-19 22:44 ` Hannes Frederic Sowa
2014-03-20 3:52 ` David Miller
2014-03-20 6:38 ` Hannes Frederic Sowa
2014-03-23 2:03 ` Hannes Frederic Sowa
2014-03-25 8:03 ` [PATCH net] ipv6: move DAD and addrconf_verify processing to workqueue Hannes Frederic Sowa
2014-03-25 21:20 ` Stephen Hemminger
2014-03-26 0:00 ` Hannes Frederic Sowa
2014-03-26 6:17 ` [PATCH v2 " Hannes Frederic Sowa
2014-03-27 17:15 ` David Miller
2014-03-27 17:28 ` [PATCH v3 " Hannes Frederic Sowa
2014-03-28 20:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319.001736.730011705431992209.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).