* [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
@ 2014-03-18 22:02 Monam Agarwal
2014-03-18 22:18 ` Paul E. McKenney
2014-03-19 20:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Monam Agarwal @ 2014-03-18 22:02 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, eddie.wai, paulmck
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) in drivers/infiniband/hw/qib/qib_qp.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
drivers/infiniband/hw/qib/qib_qp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c
index 7e7e16f..1f5f04c 100644
--- a/drivers/infiniband/hw/qib/qib_qp.c
+++ b/drivers/infiniband/hw/qib/qib_qp.c
@@ -252,10 +252,10 @@ static void remove_qp(struct qib_ibdev *dev, struct qib_qp *qp)
if (ibp->qp0 == qp) {
atomic_dec(&qp->refcount);
- rcu_assign_pointer(ibp->qp0, NULL);
+ RCU_INIT_POINTER(ibp->qp0, NULL);
} else if (ibp->qp1 == qp) {
atomic_dec(&qp->refcount);
- rcu_assign_pointer(ibp->qp1, NULL);
+ RCU_INIT_POINTER(ibp->qp1, NULL);
} else {
struct qib_qp *q, **qpp;
@@ -303,7 +303,7 @@ unsigned qib_free_all_qps(struct qib_devdata *dd)
spin_lock_irqsave(&dev->qpt_lock, flags);
for (n = 0; n < dev->qp_table_size; n++) {
qp = dev->qp_table[n];
- rcu_assign_pointer(dev->qp_table[n], NULL);
+ RCU_INIT_POINTER(dev->qp_table[n], NULL);
for (; qp; qp = qp->next)
qp_inuse++;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
2014-03-18 22:02 [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) Monam Agarwal
@ 2014-03-18 22:18 ` Paul E. McKenney
2014-03-19 20:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2014-03-18 22:18 UTC (permalink / raw)
To: Monam Agarwal; +Cc: netdev, linux-kernel, eddie.wai
On Wed, Mar 19, 2014 at 03:32:30AM +0530, Monam Agarwal wrote:
> This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) in drivers/infiniband/hw/qib/qib_qp.c
>
> Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> drivers/infiniband/hw/qib/qib_qp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c
> index 7e7e16f..1f5f04c 100644
> --- a/drivers/infiniband/hw/qib/qib_qp.c
> +++ b/drivers/infiniband/hw/qib/qib_qp.c
> @@ -252,10 +252,10 @@ static void remove_qp(struct qib_ibdev *dev, struct qib_qp *qp)
>
> if (ibp->qp0 == qp) {
> atomic_dec(&qp->refcount);
> - rcu_assign_pointer(ibp->qp0, NULL);
> + RCU_INIT_POINTER(ibp->qp0, NULL);
> } else if (ibp->qp1 == qp) {
> atomic_dec(&qp->refcount);
> - rcu_assign_pointer(ibp->qp1, NULL);
> + RCU_INIT_POINTER(ibp->qp1, NULL);
> } else {
> struct qib_qp *q, **qpp;
>
> @@ -303,7 +303,7 @@ unsigned qib_free_all_qps(struct qib_devdata *dd)
> spin_lock_irqsave(&dev->qpt_lock, flags);
> for (n = 0; n < dev->qp_table_size; n++) {
> qp = dev->qp_table[n];
> - rcu_assign_pointer(dev->qp_table[n], NULL);
> + RCU_INIT_POINTER(dev->qp_table[n], NULL);
>
> for (; qp; qp = qp->next)
> qp_inuse++;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
2014-03-18 22:02 [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) Monam Agarwal
2014-03-18 22:18 ` Paul E. McKenney
@ 2014-03-19 20:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-03-19 20:30 UTC (permalink / raw)
To: monamagarwal123; +Cc: netdev, linux-kernel, eddie.wai, paulmck
Many of your patches, such as this one, all have the same exact
subject line.
This makes it impossible to scan the subject lines and have some
idea what area a commit makes changes.
I would really suggest that you use a subject prefix that references
the driver or subsystem, so for this one:
Subject: [PATCH N/M] infiniband: Use rcu_assign_pointer(x, NULL instead) of RCU_INIT_POINTER(x, NULL)
and likewise for all of your other patches.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-19 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-18 22:02 [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) Monam Agarwal
2014-03-18 22:18 ` Paul E. McKenney
2014-03-19 20:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).