From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with no group Date: Wed, 19 Mar 2014 23:40:08 -0400 (EDT) Message-ID: <20140319.234008.1455466461924213265.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mike.rapoport@ravellosystems.com, netdev@vger.kernel.org To: dlstevens@us.ibm.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:41713 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbaCTDkM (ORCPT ); Wed, 19 Mar 2014 23:40:12 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: David Stevens Date: Wed, 19 Mar 2014 14:28:11 -0600 > > > -----David Miller wrote: ----- > >>The way I read things, we would receive packets unconditionally in >>the >>pre-ipv6-support code. So we have to keep doing so. > > I never tried it, but as there are IP-version-specific processing (the > whole reason we need to check to support both), I'd expect > that before the v6 support patch, v6-encapsulated packets would have > been dropped, or at least mishandled. We accepted all v4 packets, > because v4 is all that was supported. I'm not suggesting to mix protocols, I'm suggesting that the IPV4 path continues to accept all IPV4 packets. And we know exactly what protocol it is because the vs->rcv() caller is going to be ipv4 or ipv6 specific code.