Re: [PATCH net-next] gianfar: Fix P1010 config regression (SQ polling)

[David Miller <davem@davemloft.net>]

From: Claudiu Manoil <claudiu.manoil@freescale.com>
Date: Wed, 19 Mar 2014 15:39:39 +0200

> The P1010 device tree restricts the number of
> supported interrupt groups to 1, although the eth
> controller can support 2 interrupt groups and the
> driver assumes the Multi-Group mode ("fsl,etsec2" model).
> 
> So, in this case the assumption that the Multi-Group
> mode (MQ_MG_MODE) devices always support 2 interrupt
> groups is false.  To fix this, a check for the actual
> number of interrupt groups enabled in the board's
> device tree has been added in gfar_probe for the
> "fsl,etsec2" devices.
> 
> Without this fix, P1010 based boards claim support for
> 2 Tx queues to the net stack but only one is actually
> allocated, leading to NULL access in xmit.  This issue
> was introduced by enabling Single-Queue polling for
> the P1010 devices.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>

Please repost this, referencing the specific commit that introduced
the regression.  Either inline in the commit message, or using
the standard "Fixes: " tag right before your signoff.

Thank you.