From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] gianfar: Fix P1010 config regression (SQ polling) Date: Thu, 20 Mar 2014 16:09:44 -0400 (EDT) Message-ID: <20140320.160944.268619450160968028.davem@davemloft.net> References: <1395236379-16116-1-git-send-email-claudiu.manoil@freescale.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: claudiu.manoil@freescale.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:51004 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759323AbaCTUJq (ORCPT ); Thu, 20 Mar 2014 16:09:46 -0400 In-Reply-To: <1395236379-16116-1-git-send-email-claudiu.manoil@freescale.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Claudiu Manoil Date: Wed, 19 Mar 2014 15:39:39 +0200 > The P1010 device tree restricts the number of > supported interrupt groups to 1, although the eth > controller can support 2 interrupt groups and the > driver assumes the Multi-Group mode ("fsl,etsec2" model). > > So, in this case the assumption that the Multi-Group > mode (MQ_MG_MODE) devices always support 2 interrupt > groups is false. To fix this, a check for the actual > number of interrupt groups enabled in the board's > device tree has been added in gfar_probe for the > "fsl,etsec2" devices. > > Without this fix, P1010 based boards claim support for > 2 Tx queues to the net stack but only one is actually > allocated, leading to NULL access in xmit. This issue > was introduced by enabling Single-Queue polling for > the P1010 devices. > > Signed-off-by: Claudiu Manoil Please repost this, referencing the specific commit that introduced the regression. Either inline in the commit message, or using the standard "Fixes: " tag right before your signoff. Thank you.