From: David Miller <davem@davemloft.net>
To: wangweidong1@huawei.com
Cc: jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] atheros/atlx: use SET_ETHTOOL_OPS directly
Date: Thu, 20 Mar 2014 16:17:05 -0400 (EDT) [thread overview]
Message-ID: <20140320.161705.764874095331082303.davem@davemloft.net> (raw)
In-Reply-To: <20140320.160701.546438379437520632.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 20 Mar 2014 16:07:01 -0400 (EDT)
> From: Wang Weidong <wangweidong1@huawei.com>
> Date: Wed, 19 Mar 2014 17:39:15 +0800
>
>> As commit a6e28b34205b("staging/et131x: use SET_ETHTOOL_OPS
>> directly"), using a wrapper around SET_ETHTOOL_OPS macro is
>> not actually required, remove and use SET_ETHTOOL_OPS directly.
>>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
>
> Applied, thank you.
I reverted, you did not ever build test this:
drivers/net/ethernet/atheros/atlx/atl2.c: In function ‘atl2_probe’:
drivers/net/ethernet/atheros/atlx/atl2.c:1398:2: error: ‘atl2_ethtool_ops’ undeclared (first use in this function)
drivers/net/ethernet/atheros/atlx/atl2.c:1398:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [drivers/net/ethernet/atheros/atlx/atl2.o] Error 1
make: *** [drivers/net/ethernet/atheros/atlx/atl2.o] Error 2
If you do not even have the time to do a test build, then I do not
have the time to review and apply your patches.
next prev parent reply other threads:[~2014-03-20 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 9:39 [PATCH net-next] atheros/atlx: use SET_ETHTOOL_OPS directly Wang Weidong
2014-03-20 20:07 ` David Miller
2014-03-20 20:17 ` David Miller [this message]
2014-03-21 1:41 ` Wang Weidong
2014-03-21 1:50 ` [PATCH net-next v2] " Wang Weidong
2014-03-21 19:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320.161705.764874095331082303.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.snook@gmail.com \
--cc=jcliburn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).