* [PATCH] smsc911x: Change clock warning message to debug level
@ 2014-03-19 14:22 Fabio Estevam
2014-03-20 20:17 ` David Miller
2014-03-21 12:09 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2014-03-19 14:22 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev, davem, Fabio Estevam
Since passing the clock is not mandatory, change the warning message to debug,
so that we avoid getting the following clock failure message on every boot:
smsc911x: Driver version 2008-10-21
smsc911x smsc911x (unregistered net_device): couldn't get clock -2
libphy: smsc911x-mdio: probed
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 6382b7c..95e2b9a 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -439,7 +439,7 @@ static int smsc911x_request_resources(struct platform_device *pdev)
/* Request clock */
pdata->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(pdata->clk))
- netdev_warn(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
+ netdev_dbg(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
return ret;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] smsc911x: Change clock warning message to debug level
2014-03-19 14:22 [PATCH] smsc911x: Change clock warning message to debug level Fabio Estevam
@ 2014-03-20 20:17 ` David Miller
2014-03-21 12:09 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-03-20 20:17 UTC (permalink / raw)
To: fabio.estevam; +Cc: steve.glendinning, netdev
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Wed, 19 Mar 2014 11:22:06 -0300
> Since passing the clock is not mandatory, change the warning message to debug,
> so that we avoid getting the following clock failure message on every boot:
>
> smsc911x: Driver version 2008-10-21
> smsc911x smsc911x (unregistered net_device): couldn't get clock -2
> libphy: smsc911x-mdio: probed
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] smsc911x: Change clock warning message to debug level
2014-03-19 14:22 [PATCH] smsc911x: Change clock warning message to debug level Fabio Estevam
2014-03-20 20:17 ` David Miller
@ 2014-03-21 12:09 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2014-03-21 12:09 UTC (permalink / raw)
To: Fabio Estevam, steve.glendinning; +Cc: netdev, davem
Hello.
On 03/19/2014 05:22 PM, Fabio Estevam wrote:
> Since passing the clock is not mandatory, change the warning message to debug,
> so that we avoid getting the following clock failure message on every boot:
> smsc911x: Driver version 2008-10-21
> smsc911x smsc911x (unregistered net_device): couldn't get clock -2
> libphy: smsc911x-mdio: probed
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/net/ethernet/smsc/smsc911x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
> index 6382b7c..95e2b9a 100644
> --- a/drivers/net/ethernet/smsc/smsc911x.c
> +++ b/drivers/net/ethernet/smsc/smsc911x.c
> @@ -439,7 +439,7 @@ static int smsc911x_request_resources(struct platform_device *pdev)
> /* Request clock */
> pdata->clk = clk_get(&pdev->dev, NULL);
> if (IS_ERR(pdata->clk))
> - netdev_warn(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
> + netdev_dbg(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
Looks like using netdev_dbg() is premature at this point (see that
"unregistered net_device"), so I'd replace netdev_*(ndev, ...) with
dev_*(&pdev->dev, ...)
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-21 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-19 14:22 [PATCH] smsc911x: Change clock warning message to debug level Fabio Estevam
2014-03-20 20:17 ` David Miller
2014-03-21 12:09 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).