From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 3/3] ip6mr: fix mfc notification flags Date: Thu, 20 Mar 2014 16:25:15 -0400 (EDT) Message-ID: <20140320.162515.1111571567873898786.davem@davemloft.net> References: <1395247671-9356-1-git-send-email-nicolas.dichtel@6wind.com> <1395247671-9356-3-git-send-email-nicolas.dichtel@6wind.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tgraf@suug.ch To: nicolas.dichtel@6wind.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:51154 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759591AbaCTUZR (ORCPT ); Thu, 20 Mar 2014 16:25:17 -0400 In-Reply-To: <1395247671-9356-3-git-send-email-nicolas.dichtel@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nicolas Dichtel Date: Wed, 19 Mar 2014 17:47:51 +0100 > Commit 812e44dd1829 ("ip6mr: advertise new mfc entries via rtnl") reuses the > function ip6mr_fill_mroute() to notify mfc events. > But this function was used only for dump and thus was always setting the > flag NLM_F_MULTI, which is wrong in case of a single notification. > > Libraries like libnl will wait forever for NLMSG_DONE. > > CC: Thomas Graf > Signed-off-by: Nicolas Dichtel Applied.