From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2a 1/2] dt: Document a compatible entry for MDIO ethernet Phys
Date: Thu, 20 Mar 2014 10:19:24 -0600 [thread overview]
Message-ID: <20140320161924.GA8855@obsidianresearch.com> (raw)
In-Reply-To: <532AA634.5090707@codethink.co.uk>
On Thu, Mar 20, 2014 at 09:26:28AM +0100, Ben Dooks wrote:
> >+ If the phy's identifier is known then the list may contain an entry
> >+ of the form: "ethernet-phy-idAAAA.BBBB" where
> >+ AAAA - The value of the 16 bit Phy Identifier 1 register as
> >+ 4 hex digits. This is the chip vendor OUI bits 3:18
> >+ BBBB - The value of the 16 bit Phy Identifier 2 register as
> >+ 4 hex digits. This is the chip vendor OUI bits 19:24,
> >+ followed by 10 bits of a vendor specific ID.
> >+
>
> How about having "ethernet-phy" and adding a single property in the
> PHY node saying phy-id = <AAAABBBB>, which would be much easier to
> parse.
That option was discussed (and my first patch was this way)..
However, using the compatible string is consistent with other OF
schemes, such as PCI which uses compatible strings like pciVVVV,DDDD
pciclass,CCSS and so on.
It does make a fair amount sense because the purpose of compatible is
to identify the device.
Jason
next prev parent reply other threads:[~2014-03-20 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 22:15 [PATCH v2a 1/2] dt: Document a compatible entry for MDIO ethernet Phys Jason Gunthorpe
2014-03-19 22:15 ` [PATCH v3 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing Jason Gunthorpe
2014-03-19 22:40 ` Rob Herring
2014-03-20 21:10 ` David Miller
2014-03-20 8:26 ` [PATCH v2a 1/2] dt: Document a compatible entry for MDIO ethernet Phys Ben Dooks
2014-03-20 16:19 ` Jason Gunthorpe [this message]
2014-03-20 21:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320161924.GA8855@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).