* [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path [not found] <20140323150557.288925975@linutronix.de> @ 2014-03-23 15:09 ` Thomas Gleixner 2014-03-26 1:06 ` David Miller 2014-03-23 15:09 ` [patch 08/16] atm: idt77105: Use del_timer_sync() in exit path Thomas Gleixner 1 sibling, 1 reply; 4+ messages in thread From: Thomas Gleixner @ 2014-03-23 15:09 UTC (permalink / raw) To: LKML; +Cc: Julia Lawall, Andrew Morton, Chas Williams, atm, netdev [-- Attachment #1: atm-firestream-use-del-timer-sync.patch --] [-- Type: text/plain, Size: 877 bytes --] The device is about to vanish. So we need to make sure that the timer is completely stopped and the callback is not running on another CPU. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Chas Williams <chas@cmf.nrl.navy.mil> Cc: atm <linux-atm-general@lists.sourceforge.net> Cc: netdev <netdev@vger.kernel.org> --- drivers/atm/firestream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: tip/drivers/atm/firestream.c =================================================================== --- tip.orig/drivers/atm/firestream.c +++ tip/drivers/atm/firestream.c @@ -2000,7 +2000,7 @@ static void firestream_remove_one(struct fs_dprintk (FS_DEBUG_CLEANUP, "Freeing irq%d.\n", dev->irq); free_irq (dev->irq, dev); - del_timer (&dev->timer); + del_timer_sync (&dev->timer); atm_dev_deregister(dev->atm_dev); free_queue (dev, &dev->hp_txq); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path 2014-03-23 15:09 ` [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path Thomas Gleixner @ 2014-03-26 1:06 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2014-03-26 1:06 UTC (permalink / raw) To: tglx; +Cc: linux-kernel, Julia.Lawall, akpm, chas, linux-atm-general, netdev From: Thomas Gleixner <tglx@linutronix.de> Date: Sun, 23 Mar 2014 15:09:28 -0000 > The device is about to vanish. So we need to make sure that the timer > is completely stopped and the callback is not running on another CPU. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch 08/16] atm: idt77105: Use del_timer_sync() in exit path [not found] <20140323150557.288925975@linutronix.de> 2014-03-23 15:09 ` [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path Thomas Gleixner @ 2014-03-23 15:09 ` Thomas Gleixner 2014-03-26 1:06 ` David Miller 1 sibling, 1 reply; 4+ messages in thread From: Thomas Gleixner @ 2014-03-23 15:09 UTC (permalink / raw) To: LKML; +Cc: Julia Lawall, Andrew Morton, Chas Williams, atm, netdev [-- Attachment #1: atm-idt77x-use-del-timer-sync.patch --] [-- Type: text/plain, Size: 858 bytes --] The module is about to go away. Make sure everything is stopped safely before we pull the plug. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Chas Williams <chas@cmf.nrl.navy.mil> Cc: atm <linux-atm-general@lists.sourceforge.net> Cc: netdev <netdev@vger.kernel.org> --- drivers/atm/idt77105.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: tip/drivers/atm/idt77105.c =================================================================== --- tip.orig/drivers/atm/idt77105.c +++ tip/drivers/atm/idt77105.c @@ -368,9 +368,9 @@ EXPORT_SYMBOL(idt77105_init); static void __exit idt77105_exit(void) { - /* turn off timers */ - del_timer(&stats_timer); - del_timer(&restart_timer); + /* turn off timers */ + del_timer_sync(&stats_timer); + del_timer_sync(&restart_timer); } module_exit(idt77105_exit); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 08/16] atm: idt77105: Use del_timer_sync() in exit path 2014-03-23 15:09 ` [patch 08/16] atm: idt77105: Use del_timer_sync() in exit path Thomas Gleixner @ 2014-03-26 1:06 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2014-03-26 1:06 UTC (permalink / raw) To: tglx; +Cc: linux-kernel, Julia.Lawall, akpm, chas, linux-atm-general, netdev From: Thomas Gleixner <tglx@linutronix.de> Date: Sun, 23 Mar 2014 15:09:28 -0000 > The module is about to go away. Make sure everything is stopped safely > before we pull the plug. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-26 1:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140323150557.288925975@linutronix.de>
2014-03-23 15:09 ` [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path Thomas Gleixner
2014-03-26 1:06 ` David Miller
2014-03-23 15:09 ` [patch 08/16] atm: idt77105: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-26 1:06 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).