From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yang Subject: Re: [PATCH] net/mlx4_core: pass pci_dev_data to __mlx4_init_one Date: Mon, 24 Mar 2014 17:41:22 +0800 Message-ID: <20140324094122.GA19065@richard> References: <1395636171-17347-1-git-send-email-weiyang@linux.vnet.ibm.com> Reply-To: Wei Yang Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wei Yang , Amir Vadai , Jack Morgenstein , Or Gerlitz , David Miller , "netdev@vger.kernel.org" To: Or Gerlitz Return-path: Received: from e28smtp08.in.ibm.com ([122.248.162.8]:37546 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbaCXJln (ORCPT ); Mon, 24 Mar 2014 05:41:43 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Mar 2014 15:11:40 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 9B42E394005A for ; Mon, 24 Mar 2014 15:11:36 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2O9fTDg51249302 for ; Mon, 24 Mar 2014 15:11:30 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2O9fNZ6005259 for ; Mon, 24 Mar 2014 15:11:24 +0530 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 24, 2014 at 08:40:42AM +0200, Or Gerlitz wrote: >On Mon, Mar 24, 2014 at 6:42 AM, Wei Yang wrote: >> >> The second parameter of __mlx4_init_one() is used to identify whether the >> pci_dev is a PF or VF. Currently, when it is invoked in mlx4_pci_slot_reset() >> this information is missed. > > >This patch isn't fixing something in 3.14, right? if this is the case >I assume it's for net-next, please put a "net" or "net-next" >indication (next-time) > >Or. > Or, Thanks for your suggestion. I will pay attention next time. :-) BTW, do you like the fix? -- Richard Yang Help you, Help me