netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen-netback: Proper printf format for ptrdiff_t is 't'.
@ 2014-03-25 23:03 David Miller
  2014-03-26  9:50 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2014-03-25 23:03 UTC (permalink / raw)
  To: ian.campbell; +Cc: wei.liu2, netdev


This fixes:

drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
drivers/net/xen-netback/netback.c:1573:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]

Signed-off-by: David S. Miller <davem@davemloft.net>
---

Committed to net-next, this has been bugging me for weeks.

 drivers/net/xen-netback/netback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 1f595e5..1e46287 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1569,7 +1569,7 @@ static inline void xenvif_tx_dealloc_action(struct xenvif *vif)
 					vif->pages_to_unmap,
 					gop - vif->tx_unmap_ops);
 		if (ret) {
-			netdev_err(vif->dev, "Unmap fail: nr_ops %x ret %d\n",
+			netdev_err(vif->dev, "Unmap fail: nr_ops %tx ret %d\n",
 				   gop - vif->tx_unmap_ops, ret);
 			for (i = 0; i < gop - vif->tx_unmap_ops; ++i) {
 				if (gop[i].status != GNTST_okay)
-- 
1.8.5.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xen-netback: Proper printf format for ptrdiff_t is 't'.
  2014-03-25 23:03 [PATCH] xen-netback: Proper printf format for ptrdiff_t is 't' David Miller
@ 2014-03-26  9:50 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2014-03-26  9:50 UTC (permalink / raw)
  To: David Miller; +Cc: wei.liu2, netdev

On Tue, 2014-03-25 at 19:03 -0400, David Miller wrote:
> This fixes:
> 
> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
> drivers/net/xen-netback/netback.c:1573:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> 
> Committed to net-next, this has been bugging me for weeks.

Oops sorry. Ack to the patch FWIW.

Ian.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-26  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-25 23:03 [PATCH] xen-netback: Proper printf format for ptrdiff_t is 't' David Miller
2014-03-26  9:50 ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).