From: Stephen Hemminger <stephen@networkplumber.org>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: move DAD and addrconf_verify processing to workqueue
Date: Tue, 25 Mar 2014 14:20:04 -0700 [thread overview]
Message-ID: <20140325142004.7507d310@samsung-9> (raw)
In-Reply-To: <20140325080301.GA22086@order.stressinduktion.org>
On Tue, 25 Mar 2014 09:03:01 +0100
Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
>
> -static void addrconf_verify(unsigned long foo)
> +static void addrconf_verify_rtnl(void)
> {
> unsigned long now, next, next_sec, next_sched;
> struct inet6_ifaddr *ifp;
> int i;
>
> + ASSERT_RTNL();
> +
> rcu_read_lock_bh();
> spin_lock(&addrconf_verify_lock);
Since RTNL is now held in addrconf_verify(), is addrconf_verify_lock is not needed.
Since RTNL is held, rcu is not needed either.
Also, I would skip the wrapper (addrconf_verify_rtnl) and just
put it all in addrconf_verify_work
next prev parent reply other threads:[~2014-03-25 21:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 23:18 [PATCH net] ipv6: fix RTNL assert fail in DAD Stephen Hemminger
2014-03-18 0:29 ` Hannes Frederic Sowa
2014-03-19 0:54 ` Stephen Hemminger
2014-03-19 4:17 ` David Miller
2014-03-19 6:58 ` Stephen Hemminger
2014-03-19 17:53 ` David Miller
2014-03-19 22:44 ` Hannes Frederic Sowa
2014-03-20 3:52 ` David Miller
2014-03-20 6:38 ` Hannes Frederic Sowa
2014-03-23 2:03 ` Hannes Frederic Sowa
2014-03-25 8:03 ` [PATCH net] ipv6: move DAD and addrconf_verify processing to workqueue Hannes Frederic Sowa
2014-03-25 21:20 ` Stephen Hemminger [this message]
2014-03-26 0:00 ` Hannes Frederic Sowa
2014-03-26 6:17 ` [PATCH v2 " Hannes Frederic Sowa
2014-03-27 17:15 ` David Miller
2014-03-27 17:28 ` [PATCH v3 " Hannes Frederic Sowa
2014-03-28 20:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325142004.7507d310@samsung-9 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox