From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] tcp: tcp_make_synack() minor changes Date: Wed, 26 Mar 2014 14:25:51 -0400 (EDT) Message-ID: <20140326.142551.19958322633174107.davem@davemloft.net> References: <1395853039.12610.217.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45084 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbaCZS0G (ORCPT ); Wed, 26 Mar 2014 14:26:06 -0400 In-Reply-To: <1395853039.12610.217.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Wed, 26 Mar 2014 09:57:19 -0700 > From: Eric Dumazet > > There is no need to allocate 15 bytes in excess for a SYNACK packet, > as it contains no data, only headers. > > SYNACK are always generated in softirq context, and contain a single > segment, we can use TCP_INC_STATS_BH() > > Signed-off-by: Eric Dumazet ... > - skb = sock_wmalloc(sk, MAX_TCP_HEADER + 15, 1, GFP_ATOMIC); > + skb = sock_wmalloc(sk, MAX_TCP_HEADER, 1, GFP_ATOMIC); Do you know where this "+ 15" comes from? :-) It is a kind of Linux networking trivia question.