* [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered
@ 2014-03-24 15:57 Fabio Estevam
2014-03-24 15:57 ` [PATCH 2/2] smsc911x: No need to print driver version Fabio Estevam
2014-03-26 19:46 ` [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2014-03-24 15:57 UTC (permalink / raw)
To: davem; +Cc: steve.glendinning, netdev, Fabio Estevam, Sergei Shtylyov
With debug enabled we get the following message:
smsc911x smsc911x (unregistered net_device): couldn't get clock -2
As the device has not been registered at this point, it is better to use
dev_dbg() instead of netdev_dbg().
CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 95e2b9a..c6a5e89 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -439,7 +439,8 @@ static int smsc911x_request_resources(struct platform_device *pdev)
/* Request clock */
pdata->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(pdata->clk))
- netdev_dbg(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
+ dev_dbg(&pdev->dev, "couldn't get clock %li\n",
+ PTR_ERR(pdata->clk));
return ret;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] smsc911x: No need to print driver version
2014-03-24 15:57 [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered Fabio Estevam
@ 2014-03-24 15:57 ` Fabio Estevam
2014-03-26 19:46 ` David Miller
2014-03-26 19:46 ` [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2014-03-24 15:57 UTC (permalink / raw)
To: davem; +Cc: steve.glendinning, netdev, Fabio Estevam
Having the kernel to print:
"smsc911x: Driver version 2008-10-21" on every boot is not very useful, so
remove the print of the driver version.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index c6a5e89..5f31543 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2380,8 +2380,6 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
int res_size, irq_flags;
int retval;
- pr_info("Driver version %s\n", SMSC_DRV_VERSION);
-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"smsc911x-memory");
if (!res)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered
2014-03-24 15:57 [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered Fabio Estevam
2014-03-24 15:57 ` [PATCH 2/2] smsc911x: No need to print driver version Fabio Estevam
@ 2014-03-26 19:46 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2014-03-26 19:46 UTC (permalink / raw)
To: fabio.estevam; +Cc: steve.glendinning, netdev, sergei.shtylyov
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Mon, 24 Mar 2014 12:57:25 -0300
> With debug enabled we get the following message:
>
> smsc911x smsc911x (unregistered net_device): couldn't get clock -2
>
> As the device has not been registered at this point, it is better to use
> dev_dbg() instead of netdev_dbg().
>
> CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered
@ 2014-03-24 15:34 Fabio Estevam
2014-03-24 15:34 ` [PATCH 2/2] smsc911x: No need to print driver version Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2014-03-24 15:34 UTC (permalink / raw)
To: davem; +Cc: steve.glendinning, netdev, Fabio Estevam, Sergei Shtylyov
With debug enabled we get the following message:
smsc911x smsc911x (unregistered net_device): couldn't get clock -2
As the device has not been registered at this point, it is better to use
dev_dbg() instead of netdev_dbg().
CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 95e2b9a..c6a5e89 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -439,7 +439,8 @@ static int smsc911x_request_resources(struct platform_device *pdev)
/* Request clock */
pdata->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(pdata->clk))
- netdev_dbg(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
+ dev_dbg(&pdev->dev, "couldn't get clock %li\n",
+ PTR_ERR(pdata->clk));
return ret;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] smsc911x: No need to print driver version
2014-03-24 15:34 Fabio Estevam
@ 2014-03-24 15:34 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2014-03-24 15:34 UTC (permalink / raw)
To: davem; +Cc: steve.glendinning, netdev, Fabio Estevam
Having the kernel to print:
"smsc911x: Driver version 2008-10-21" on every boot is not very useful, so
remove the print of the driver version.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index c6a5e89..5f31543 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2380,8 +2380,6 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
int res_size, irq_flags;
int retval;
- pr_info("Driver version %s\n", SMSC_DRV_VERSION);
-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"smsc911x-memory");
if (!res)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-26 19:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-24 15:57 [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered Fabio Estevam
2014-03-24 15:57 ` [PATCH 2/2] smsc911x: No need to print driver version Fabio Estevam
2014-03-26 19:46 ` David Miller
2014-03-26 19:46 ` [PATCH 1/2] smsc911x: Do not use netdev_dbg() when device is not registered David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-03-24 15:34 Fabio Estevam
2014-03-24 15:34 ` [PATCH 2/2] smsc911x: No need to print driver version Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).