[PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
       [not found] <1395746646-28299-1-git-send-email-christian.riesch@omicron.at>
@ 2014-03-25 11:24 ` Christian Riesch
  2014-03-25 11:45   ` Richard Cochran
  2014-03-26 20:44   ` David Miller
  0 siblings, 2 replies; 8+ messages in thread
From: Christian Riesch @ 2014-03-25 11:24 UTC (permalink / raw)
  To: netdev; +Cc: Richard Cochran, Christian Riesch, Dong Zhu

Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
Cc: Dong Zhu <bluezhudong@gmail.com>
---
 Documentation/ptp/testptp.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
index 13bddd5..14bf19e 100644
--- a/Documentation/ptp/testptp.c
+++ b/Documentation/ptp/testptp.c
@@ -496,14 +496,14 @@ int main(int argc, char *argv[])
 			interval = t2 - t1;
 			offset = (t2 + t1) / 2 - tp;
 
-			printf("system time: %ld.%ld\n",
+			printf("system time: %lld.%u\n",
 				(pct+2*i)->sec, (pct+2*i)->nsec);
-			printf("phc    time: %ld.%ld\n",
+			printf("phc    time: %lld.%u\n",
 				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
-			printf("system time: %ld.%ld\n",
+			printf("system time: %lld.%u\n",
 				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
-			printf("system/phc clock time offset is %ld ns\n"
-				"system     clock time delay  is %ld ns\n",
+			printf("system/phc clock time offset is %lld ns\n"
+				"system     clock time delay  is %lld ns\n",
 				offset, interval);
 		}
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-03-25 11:24 ` [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility Christian Riesch
@ 2014-03-25 11:45   ` Richard Cochran
  2014-04-08 21:43     ` Keller, Jacob E
  2014-03-26 20:44   ` David Miller
  1 sibling, 1 reply; 8+ messages in thread
From: Richard Cochran @ 2014-03-25 11:45 UTC (permalink / raw)
  To: Christian Riesch; +Cc: netdev, Dong Zhu

On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Dong Zhu <bluezhudong@gmail.com>
> ---
>  Documentation/ptp/testptp.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
> index 13bddd5..14bf19e 100644
> --- a/Documentation/ptp/testptp.c
> +++ b/Documentation/ptp/testptp.c
> @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
>  			interval = t2 - t1;
>  			offset = (t2 + t1) / 2 - tp;
>  
> -			printf("system time: %ld.%ld\n",
> +			printf("system time: %lld.%u\n",
>  				(pct+2*i)->sec, (pct+2*i)->nsec);
> -			printf("phc    time: %ld.%ld\n",
> +			printf("phc    time: %lld.%u\n",
>  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
> -			printf("system time: %ld.%ld\n",
> +			printf("system time: %lld.%u\n",
>  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
> -			printf("system/phc clock time offset is %ld ns\n"
> -				"system     clock time delay  is %ld ns\n",

Use PRId64 instead?

Thanks,
Richard

> +			printf("system/phc clock time offset is %lld ns\n"
> +				"system     clock time delay  is %lld ns\n",
>  				offset, interval);
>  		}
>  
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-03-25 11:45   ` Richard Cochran
@ 2014-04-08 21:43     ` Keller, Jacob E
  2014-04-09  6:15       ` Christian Riesch
                         ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Keller, Jacob E @ 2014-04-08 21:43 UTC (permalink / raw)
  To: Richard Cochran; +Cc: Christian Riesch, netdev@vger.kernel.org, Dong Zhu

On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote:
> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
> > Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> > Cc: Dong Zhu <bluezhudong@gmail.com>
> > ---
> >  Documentation/ptp/testptp.c |   10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
> > index 13bddd5..14bf19e 100644
> > --- a/Documentation/ptp/testptp.c
> > +++ b/Documentation/ptp/testptp.c
> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
> >  			interval = t2 - t1;
> >  			offset = (t2 + t1) / 2 - tp;
> >  
> > -			printf("system time: %ld.%ld\n",
> > +			printf("system time: %lld.%u\n",
> >  				(pct+2*i)->sec, (pct+2*i)->nsec);
> > -			printf("phc    time: %ld.%ld\n",
> > +			printf("phc    time: %lld.%u\n",
> >  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
> > -			printf("system time: %ld.%ld\n",
> > +			printf("system time: %lld.%u\n",
> >  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
> > -			printf("system/phc clock time offset is %ld ns\n"
> > -				"system     clock time delay  is %ld ns\n",
> 
> Use PRId64 instead?
> 
> Thanks,
> Richard
> 

I agree with this. %lld is not going to resolve the error properly on a
32 bit machine. Looks like a follow-on patch would have to be generated,
since Dave applied this already.

Thanks,
Jake

> > +			printf("system/phc clock time offset is %lld ns\n"
> > +				"system     clock time delay  is %lld ns\n",
> >  				offset, interval);
> >  		}
> >  
> > -- 
> > 1.7.9.5
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-04-08 21:43     ` Keller, Jacob E
@ 2014-04-09  6:15       ` Christian Riesch
  2014-04-09  6:23       ` Christian Riesch
  2014-04-09  6:40       ` Christian Riesch
  2 siblings, 0 replies; 8+ messages in thread
From: Christian Riesch @ 2014-04-09  6:15 UTC (permalink / raw)
  To: Keller, Jacob E, Richard Cochran; +Cc: Christian Riesch, netdev, Dong Zhu


--On April 08, 2014 21:43 +0000 "Keller, Jacob E" 
<jacob.e.keller@intel.com> wrote:
> On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote:
>> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
>> > Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
>> > Cc: Dong Zhu <bluezhudong@gmail.com>
>> > ---
>> >  Documentation/ptp/testptp.c |   10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
>> > index 13bddd5..14bf19e 100644
>> > --- a/Documentation/ptp/testptp.c
>> > +++ b/Documentation/ptp/testptp.c
>> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
>> >  			interval = t2 - t1;
>> >  			offset = (t2 + t1) / 2 - tp;
>> >
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i)->sec, (pct+2*i)->nsec);
>> > -			printf("phc    time: %ld.%ld\n",
>> > +			printf("phc    time: %lld.%u\n",
>> >  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
>> > -			printf("system/phc clock time offset is %ld ns\n"
>> > -				"system     clock time delay  is %ld ns\n",
>>
>> Use PRId64 instead?
>>
>> Thanks,
>> Richard
>>
>
> I agree with this. %lld is not going to resolve the error properly on a
> 32 bit machine. Looks like a follow-on patch would have to be generated,
> since Dave applied this already.

Thanks for catching this. I read the "applied" message from David but 
didn't notice that he applied v1 of the patch, v2 was the one with PRId64. 
I'll prepare a follow-up patch.
Christian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-04-08 21:43     ` Keller, Jacob E
  2014-04-09  6:15       ` Christian Riesch
@ 2014-04-09  6:23       ` Christian Riesch
  2014-04-09  6:40       ` Christian Riesch
  2 siblings, 0 replies; 8+ messages in thread
From: Christian Riesch @ 2014-04-09  6:23 UTC (permalink / raw)
  To: Keller, Jacob E, Richard Cochran; +Cc: Christian Riesch, netdev, Dong Zhu



--On April 08, 2014 21:43 +0000 "Keller, Jacob E" 
<jacob.e.keller@intel.com> wrote:

> On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote:
>> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
>> > Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
>> > Cc: Dong Zhu <bluezhudong@gmail.com>
>> > ---
>> >  Documentation/ptp/testptp.c |   10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
>> > index 13bddd5..14bf19e 100644
>> > --- a/Documentation/ptp/testptp.c
>> > +++ b/Documentation/ptp/testptp.c
>> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
>> >  			interval = t2 - t1;
>> >  			offset = (t2 + t1) / 2 - tp;
>> >
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i)->sec, (pct+2*i)->nsec);
>> > -			printf("phc    time: %ld.%ld\n",
>> > +			printf("phc    time: %lld.%u\n",
>> >  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
>> > -			printf("system/phc clock time offset is %ld ns\n"
>> > -				"system     clock time delay  is %ld ns\n",
>>
>> Use PRId64 instead?
>>
>> Thanks,
>> Richard
>>
>
> I agree with this. %lld is not going to resolve the error properly on a
> 32 bit machine.

Actually, %lld solves the problem on a 32 bit machine (this is what I am 
compiling for), but it will cause warnings on 64 bit, right?
Christian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-04-08 21:43     ` Keller, Jacob E
  2014-04-09  6:15       ` Christian Riesch
  2014-04-09  6:23       ` Christian Riesch
@ 2014-04-09  6:40       ` Christian Riesch
  2014-04-09 17:33         ` Keller, Jacob E
  2 siblings, 1 reply; 8+ messages in thread
From: Christian Riesch @ 2014-04-09  6:40 UTC (permalink / raw)
  To: Keller, Jacob E, Richard Cochran; +Cc: Christian Riesch, netdev, Dong Zhu



--On April 08, 2014 21:43 +0000 "Keller, Jacob E" 
<jacob.e.keller@intel.com> wrote:

> On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote:
>> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
>> > Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
>> > Cc: Dong Zhu <bluezhudong@gmail.com>
>> > ---
>> >  Documentation/ptp/testptp.c |   10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
>> > index 13bddd5..14bf19e 100644
>> > --- a/Documentation/ptp/testptp.c
>> > +++ b/Documentation/ptp/testptp.c
>> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
>> >  			interval = t2 - t1;
>> >  			offset = (t2 + t1) / 2 - tp;
>> >
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i)->sec, (pct+2*i)->nsec);
>> > -			printf("phc    time: %ld.%ld\n",
>> > +			printf("phc    time: %lld.%u\n",
>> >  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
>> > -			printf("system time: %ld.%ld\n",
>> > +			printf("system time: %lld.%u\n",
>> >  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
>> > -			printf("system/phc clock time offset is %ld ns\n"
>> > -				"system     clock time delay  is %ld ns\n",
>>
>> Use PRId64 instead?
>>
>> Thanks,
>> Richard
>>
>
> I agree with this. %lld is not going to resolve the error properly on a
> 32 bit machine. Looks like a follow-on patch would have to be generated,
> since Dave applied this already.

I checked again, no follow-up patch is required: David first applied v1 
(commit 203191c386e83b8c5d95bbbaef13baa629512726), later reverted it 
(031fe792ccd4f5d79415b219c73b868da98d9b70), and applied v2 
(4ec54f95736f2d90e4d9e4fcc75cf1228f0f3ede).

Thanks, Christian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-04-09  6:40       ` Christian Riesch
@ 2014-04-09 17:33         ` Keller, Jacob E
  0 siblings, 0 replies; 8+ messages in thread
From: Keller, Jacob E @ 2014-04-09 17:33 UTC (permalink / raw)
  To: Christian Riesch
  Cc: Richard Cochran, Christian Riesch, netdev@vger.kernel.org,
	Dong Zhu

On Wed, 2014-04-09 at 08:40 +0200, Christian Riesch wrote:
> 
> --On April 08, 2014 21:43 +0000 "Keller, Jacob E" 
> <jacob.e.keller@intel.com> wrote:
> 
> > On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote:
> >> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote:
> >> > Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> >> > Cc: Dong Zhu <bluezhudong@gmail.com>
> >> > ---
> >> >  Documentation/ptp/testptp.c |   10 +++++-----
> >> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >> >
> >> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
> >> > index 13bddd5..14bf19e 100644
> >> > --- a/Documentation/ptp/testptp.c
> >> > +++ b/Documentation/ptp/testptp.c
> >> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[])
> >> >  			interval = t2 - t1;
> >> >  			offset = (t2 + t1) / 2 - tp;
> >> >
> >> > -			printf("system time: %ld.%ld\n",
> >> > +			printf("system time: %lld.%u\n",
> >> >  				(pct+2*i)->sec, (pct+2*i)->nsec);
> >> > -			printf("phc    time: %ld.%ld\n",
> >> > +			printf("phc    time: %lld.%u\n",
> >> >  				(pct+2*i+1)->sec, (pct+2*i+1)->nsec);
> >> > -			printf("system time: %ld.%ld\n",
> >> > +			printf("system time: %lld.%u\n",
> >> >  				(pct+2*i+2)->sec, (pct+2*i+2)->nsec);
> >> > -			printf("system/phc clock time offset is %ld ns\n"
> >> > -				"system     clock time delay  is %ld ns\n",
> >>
> >> Use PRId64 instead?
> >>
> >> Thanks,
> >> Richard
> >>
> >
> > I agree with this. %lld is not going to resolve the error properly on a
> > 32 bit machine. Looks like a follow-on patch would have to be generated,
> > since Dave applied this already.
> 
> I checked again, no follow-up patch is required: David first applied v1 
> (commit 203191c386e83b8c5d95bbbaef13baa629512726), later reverted it 
> (031fe792ccd4f5d79415b219c73b868da98d9b70), and applied v2 
> (4ec54f95736f2d90e4d9e4fcc75cf1228f0f3ede).
> 
> Thanks, Christian

And yes, you were right %lld works for 32bit but not 64bit. I had it
backwards.

Thanks,
Jake

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility
  2014-03-25 11:24 ` [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility Christian Riesch
  2014-03-25 11:45   ` Richard Cochran
@ 2014-03-26 20:44   ` David Miller
  1 sibling, 0 replies; 8+ messages in thread
From: David Miller @ 2014-03-26 20:44 UTC (permalink / raw)
  To: christian.riesch; +Cc: netdev, richardcochran, bluezhudong

From: Christian Riesch <christian.riesch@omicron.at>
Date: Tue, 25 Mar 2014 12:24:06 +0100

> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>

Applied.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-04-09 17:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1395746646-28299-1-git-send-email-christian.riesch@omicron.at>
2014-03-25 11:24 ` [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility Christian Riesch
2014-03-25 11:45   ` Richard Cochran
2014-04-08 21:43     ` Keller, Jacob E
2014-04-09  6:15       ` Christian Riesch
2014-04-09  6:23       ` Christian Riesch
2014-04-09  6:40       ` Christian Riesch
2014-04-09 17:33         ` Keller, Jacob E
2014-03-26 20:44   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).