From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: wangyufen@huawei.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] net: tcp_ipv6 do some cleanup
Date: Wed, 26 Mar 2014 17:07:20 -0400 (EDT) [thread overview]
Message-ID: <20140326.170720.1620895694123455490.davem@davemloft.net> (raw)
In-Reply-To: <1395866443.3726.43.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Wed, 26 Mar 2014 13:40:43 -0700
> On Wed, 2014-03-26 at 15:42 -0400, David Miller wrote:
>> From: Wangyufen <wangyufen@huawei.com>
>> Date: Mon, 24 Mar 2014 14:25:21 +0800
>>
>> > -static int tcp_v6_parse_md5_keys (struct sock *sk, char __user *optval,
>> > +static int tcp_v6_parse_md5_keys(struct sock *sk, char __user *optval,
>> > int optlen)
>>
>> If you change the first line, you must adjust the indentation of the second
>> line so that "int optlen)" begins precisely at the first column after the
>> openning parenthesis on the first line.
>
> checkpatch's --strict option emits a message about alignment
> issues like this.
>
> David, do you want the --strict option to be auto-enabled for
> patches of files in drivers/net and net/?
I know this doesn't help, but I'm ambivalent.
next prev parent reply other threads:[~2014-03-26 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 6:25 [PATCH net-next v3 1/2] net: tcp_ipv6 do some cleanup Wangyufen
2014-03-24 6:25 ` [PATCH net-next v3 2/2] net: tcp_ipv6 policy route issue Wangyufen
2014-03-26 7:05 ` Hannes Frederic Sowa
2014-03-27 2:00 ` wangyufen
2014-03-27 5:32 ` Hannes Frederic Sowa
2014-03-28 1:11 ` wangyufen
2014-03-26 19:42 ` [PATCH net-next v3 1/2] net: tcp_ipv6 do some cleanup David Miller
2014-03-26 20:40 ` Joe Perches
2014-03-26 21:07 ` David Miller [this message]
2014-03-27 1:18 ` wangyufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140326.170720.1620895694123455490.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).