netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
	bridge@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] net: Allow modules to use is_skb_forwardable
Date: Wed, 26 Mar 2014 14:35:19 -0700	[thread overview]
Message-ID: <20140326143519.72ea3cc6@samsung-9> (raw)
In-Reply-To: <1395849627-15711-3-git-send-email-vyasevic@redhat.com>

On Wed, 26 Mar 2014 12:00:26 -0400
Vlad Yasevich <vyasevic@redhat.com> wrote:

> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> ---
>  include/linux/netdevice.h | 1 +
>  net/core/dev.c            | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index e8eeebd..d855794 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2551,6 +2551,7 @@ int dev_get_phys_port_id(struct net_device *dev,
>  int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
>  			struct netdev_queue *txq);
>  int dev_forward_skb(struct net_device *dev, struct sk_buff *skb);
> +bool is_skb_forwardable(struct net_device *dev, struct sk_buff *skb);
>  
>  extern int		netdev_budget;
>  
> diff --git a/net/core/dev.c b/net/core/dev.c
> index b1b0c8d..a98f7fa 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1645,7 +1645,7 @@ static inline void net_timestamp_set(struct sk_buff *skb)
>  			__net_timestamp(SKB);		\
>  	}						\
>  
> -static inline bool is_skb_forwardable(struct net_device *dev,
> +bool is_skb_forwardable(struct net_device *dev,
>  				      struct sk_buff *skb)
>  {
>  	unsigned int len;
> @@ -1665,6 +1665,7 @@ static inline bool is_skb_forwardable(struct net_device *dev,
>  
>  	return false;
>  }
> +EXPORT_SYMBOL_GPL(is_skb_forwardable);
>  
>  /**
>   * dev_forward_skb - loopback an skb to another netif

This will allow an arbitrary 1522 byte frame to be forwarded.
Not sure if this ok.

  reply	other threads:[~2014-03-26 21:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26 16:00 [PATCH 0/2] bridge: Fix forwarding of 8021AD frames Vlad Yasevich
2014-03-26 16:00 ` Vlad Yasevich
2014-03-26 16:00 ` [PATCH 1/2] net: Allow modules to use is_skb_forwardable Vlad Yasevich
2014-03-26 21:35   ` Stephen Hemminger [this message]
2014-03-27  0:50     ` Vlad Yasevich
2014-03-26 16:00 ` [PATCH 2/2] bridge: use is_skb_forwardable in forward path Vlad Yasevich
2014-03-26 16:09 ` [PATCH 0/2] bridge: Fix forwarding of 8021AD frames Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140326143519.72ea3cc6@samsung-9 \
    --to=stephen@networkplumber.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).