From: Michal Kubecek <mkubecek@suse.cz>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [PATCH net-next v3] ipv6: do not overwrite inetpeer metrics prematurely
Date: Wed, 26 Mar 2014 16:56:06 +0100 [thread overview]
Message-ID: <20140326155606.GC27720@unicorn.suse.cz> (raw)
In-Reply-To: <20140326155047.GG22086@order.stressinduktion.org>
On Wed, Mar 26, 2014 at 04:50:47PM +0100, Hannes Frederic Sowa wrote:
> On Wed, Mar 26, 2014 at 04:42:45PM +0100, Michal Kubecek wrote:
> > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > index fba54a4..b6dda6a 100644
> > --- a/net/ipv6/route.c
> > +++ b/net/ipv6/route.c
> > @@ -149,8 +149,10 @@ static u32 *ipv6_cow_metrics(struct dst_entry *dst, unsigned long old)
> > unsigned long prev, new;
> >
> > p = peer->metrics;
> > - if (inet_metrics_new(peer))
> > + if (inet_metrics_new(peer) || (dst->flags | DST_KEEP_METRICS)) {
> > memcpy(p, old_p, sizeof(u32) * RTAX_MAX);
> > + dst->flags &= ~DST_KEEP_METRICS;
> > + }
>
> The (dst->flags | DST_KEEP_METRICS) looks very suspicious. ;)
Oops. I already fixed this typo... and then did the submission from a
different branch. :-(
Michal Kubecek
next prev parent reply other threads:[~2014-03-26 15:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 9:50 [PATCH net] ipv6: do not overwrite inetpeer metrics prematurely Michal Kubecek
2014-03-06 19:24 ` David Miller
2014-03-06 20:06 ` Michal Kubecek
2014-03-07 12:36 ` [PATCH net v2] " Michal Kubecek
2014-03-07 20:52 ` [PATCH net] " David Miller
2014-03-07 21:38 ` Michal Kubecek
2014-03-08 8:34 ` Hannes Frederic Sowa
2014-03-08 8:06 ` Hannes Frederic Sowa
2014-03-10 0:26 ` David Miller
2014-03-10 0:52 ` Hannes Frederic Sowa
2014-03-10 5:03 ` David Miller
2014-03-10 8:15 ` Michal Kubecek
2014-03-10 12:00 ` Hannes Frederic Sowa
2014-03-10 13:15 ` Michal Kubecek
2014-03-11 2:38 ` David Miller
2014-03-11 9:53 ` Michal Kubecek
2014-03-11 15:08 ` Michal Kubecek
2014-03-11 15:20 ` Hannes Frederic Sowa
2014-03-11 15:39 ` Michal Kubecek
2014-03-25 19:11 ` Hannes Frederic Sowa
2014-03-26 15:09 ` Michal Kubecek
2014-03-26 15:42 ` [PATCH net-next v3] " Michal Kubecek
2014-03-26 15:50 ` Hannes Frederic Sowa
2014-03-26 15:56 ` Michal Kubecek [this message]
2014-03-26 16:05 ` [PATCH net-next v4] " Michal Kubecek
2014-03-27 5:06 ` Hannes Frederic Sowa
2014-03-27 7:43 ` Michal Kubecek
2014-03-27 12:04 ` [PATCH net-next v5] " Michal Kubecek
2014-03-27 16:30 ` Hannes Frederic Sowa
2014-03-27 19:09 ` David Miller
2014-03-12 20:54 ` [PATCH net] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140326155606.GC27720@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).