From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: vyasevic@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] vlan: Mask off vlan acceleration features on vlan device.
Date: Wed, 26 Mar 2014 21:15:05 +0000 [thread overview]
Message-ID: <20140326211504.GA21393@macbook.localnet> (raw)
In-Reply-To: <20140326.171038.2150319831233512825.davem@davemloft.net>
On Wed, Mar 26, 2014 at 05:10:38PM -0400, David Miller wrote:
> From: Vlad Yasevich <vyasevic@redhat.com>
> Date: Wed, 26 Mar 2014 16:28:31 -0400
>
> > Some drivers incorrectly assign vlan acceleration features to
> > vlan_features thus causing issues for Q-in-Q vlan configurations.
> > Prevent this once and for all by masking off acceleration features
> > for vlan devices until such time as we support stacked acceleration.
> >
> > Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
>
> So what if we do have chips that can offload Q-in-Q? Will we use
> a new flag?
For 802.1ad that was the intention, using the NETIF_F_HW_VLAN_STAG_* flags.
next prev parent reply other threads:[~2014-03-26 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 21:52 [PATCH] tg3: Do not include vlan acceleration features in vlan_features Vlad Yasevich
2014-03-26 19:56 ` David Miller
2014-03-26 20:25 ` [PATCH net] vlan: Mask off vlan acceleration features on vlan device Vlad Yasevich
2014-03-26 20:26 ` Vlad Yasevich
2014-03-26 20:28 ` [PATCH v2 " Vlad Yasevich
2014-03-26 21:10 ` David Miller
2014-03-26 21:15 ` Patrick McHardy [this message]
2014-03-27 0:53 ` Vlad Yasevich
2014-03-27 8:14 ` Patrick McHardy
2014-03-27 1:03 ` Vlad Yasevich
2014-03-27 19:12 ` David Miller
2014-03-27 20:25 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140326211504.GA21393@macbook.localnet \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).