From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] ipv6: move DAD and addrconf_verify processing to workqueue
Date: Thu, 27 Mar 2014 13:15:49 -0400 (EDT) [thread overview]
Message-ID: <20140327.131549.909533657131515923.davem@davemloft.net> (raw)
In-Reply-To: <20140326061745.GE22086@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Wed, 26 Mar 2014 07:17:45 +0100
> @@ -751,7 +753,7 @@ void inet6_ifa_finish_destroy(struct inet6_ifaddr *ifp)
>
> in6_dev_put(ifp->idev);
>
> - if (del_timer(&ifp->dad_timer))
> + if (cancel_delayed_work(&ifp->dad_work))
> pr_notice("Timer is still running, when freeing ifa=%p\n", ifp);
>
> if (ifp->state != INET6_IFADDR_STATE_DEAD) {
This pr_notice() needs to be adjusted, we are no longer using a timer.
next prev parent reply other threads:[~2014-03-27 17:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 23:18 [PATCH net] ipv6: fix RTNL assert fail in DAD Stephen Hemminger
2014-03-18 0:29 ` Hannes Frederic Sowa
2014-03-19 0:54 ` Stephen Hemminger
2014-03-19 4:17 ` David Miller
2014-03-19 6:58 ` Stephen Hemminger
2014-03-19 17:53 ` David Miller
2014-03-19 22:44 ` Hannes Frederic Sowa
2014-03-20 3:52 ` David Miller
2014-03-20 6:38 ` Hannes Frederic Sowa
2014-03-23 2:03 ` Hannes Frederic Sowa
2014-03-25 8:03 ` [PATCH net] ipv6: move DAD and addrconf_verify processing to workqueue Hannes Frederic Sowa
2014-03-25 21:20 ` Stephen Hemminger
2014-03-26 0:00 ` Hannes Frederic Sowa
2014-03-26 6:17 ` [PATCH v2 " Hannes Frederic Sowa
2014-03-27 17:15 ` David Miller [this message]
2014-03-27 17:28 ` [PATCH v3 " Hannes Frederic Sowa
2014-03-28 20:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327.131549.909533657131515923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).