From: Flavio Leitner <fbl@redhat.com>
To: netdev <netdev@vger.kernel.org>
Cc: openvswitch <dev@openvswitch.org>
Subject: Re: [PATCH net] openvswitch: fix a possible deadlock and lockdep warning
Date: Thu, 27 Mar 2014 09:52:42 -0300 [thread overview]
Message-ID: <20140327125242.GA2475@t520.home> (raw)
In-Reply-To: <1395881772-29781-1-git-send-email-fbl@redhat.com>
Please ignore this one.
I will repost with the correct openvswitch address.
Thanks
On Wed, Mar 26, 2014 at 09:56:12PM -0300, Flavio Leitner wrote:
> There are two problematic situations.
>
> A deadlock can happen when is_percpu is false because it can get
> interrupted while holding the spinlock. Then it executes
> ovs_flow_stats_update() in softirq context which tries to get
> the same lock.
>
> The second sitation is that when is_percpu is true, the code
> correctly disables BH only for the local CPU, but that confuses
> lockdep enough to trigger the warning below.
>
> This patch disables BH for both cases fixing the real deadlock
> and the lockdep warning message.
[...]
next prev parent reply other threads:[~2014-03-27 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 0:56 [PATCH net] openvswitch: fix a possible deadlock and lockdep warning Flavio Leitner
2014-03-27 12:52 ` Flavio Leitner [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-27 12:53 Flavio Leitner
[not found] ` <1395924836-3182-1-git-send-email-fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-03-28 20:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327125242.GA2475@t520.home \
--to=fbl@redhat.com \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).