From: David Miller <davem@davemloft.net>
To: ben.dooks@codethink.co.uk
Cc: linux-kernel@lists.codethink.co.uk, netdev@vger.kernel.org,
linux-sh@vger.kernel.org, sergei.shtylyov@cogentembedded.com,
laurent.pinchart+renesas@ideasonboard.com
Subject: Re: [PATCH v5] sh_eth: ensure pm_runtime cannot suspend the device during init
Date: Fri, 28 Mar 2014 14:26:06 -0400 (EDT) [thread overview]
Message-ID: <20140328.142606.2032782733436495474.davem@davemloft.net> (raw)
In-Reply-To: <1395400154-25710-1-git-send-email-ben.dooks@codethink.co.uk>
From: Ben Dooks <ben.dooks@codethink.co.uk>
Date: Fri, 21 Mar 2014 12:09:14 +0100
> The pm_rumtime work queue is causing the device to be suspended during
> initialisation, thus the initialisation may not be able to access registers
> properly. As the code is called from a work queue, it is possible that this
> is not seen from certain configurations/builds due to the asynchronos
> nature of the code.
>
> Another issue has also been found where the network device registration
> calls back into the driver thus causing further pm_runtime calls that
> also caused issues with the MDIO bus code. This has now been checked
> and is the only place the MDIO can be called without the device open.
>
> Use pm_runtime_get_sync() and pm_runtime_put() to ensure that the
> pm system does not suspend it during the probe() call and remove the
> now unnecessary pm_runtime_resume() call. Also add a call in the error
> path to call pm_runtime_disable().
>
> This fixes the external abort that can cause /sbin/init or other such
> init processed to die.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
What tree is this against? It doesn't apply cleanly to 'net'.
next prev parent reply other threads:[~2014-03-28 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 11:09 [PATCH v5] sh_eth: ensure pm_runtime cannot suspend the device during init Ben Dooks
2014-03-21 12:14 ` Geert Uytterhoeven
2014-03-21 13:00 ` Laurent Pinchart
2014-03-28 18:26 ` David Miller [this message]
2014-03-28 19:25 ` Ben Dooks
2014-03-28 20:00 ` David Miller
2014-03-28 21:10 ` Sergei Shtylyov
2014-03-28 21:18 ` David Miller
2014-03-29 13:52 ` Sergei Shtylyov
2014-03-29 19:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328.142606.2032782733436495474.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.dooks@codethink.co.uk \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).