* [PATCH net-next] net: nlmon: flag nlmon devs with LLTX/SG
@ 2014-03-27 15:34 Daniel Borkmann
2014-03-27 16:09 ` Eric Dumazet
2014-03-28 20:50 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Borkmann @ 2014-03-27 15:34 UTC (permalink / raw)
To: davem; +Cc: netdev
As in xmit path we merely update statistics and free the skb, we
can mark the device with LLTX feature, so that upper layers can
avoid taking the single txq lock on xmit. While at it, also add
missing NETIF_F_SG.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
drivers/net/nlmon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c
index 6929b03..34924df 100644
--- a/drivers/net/nlmon.c
+++ b/drivers/net/nlmon.c
@@ -136,7 +136,8 @@ static void nlmon_setup(struct net_device *dev)
dev->ethtool_ops = &nlmon_ethtool_ops;
dev->destructor = free_netdev;
- dev->features = NETIF_F_FRAGLIST | NETIF_F_HIGHDMA;
+ dev->features = NETIF_F_SG | NETIF_F_FRAGLIST |
+ NETIF_F_HIGHDMA | NETIF_F_LLTX;
dev->flags = IFF_NOARP;
/* That's rather a softlimit here, which, of course,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: nlmon: flag nlmon devs with LLTX/SG
2014-03-27 15:34 [PATCH net-next] net: nlmon: flag nlmon devs with LLTX/SG Daniel Borkmann
@ 2014-03-27 16:09 ` Eric Dumazet
2014-03-28 20:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2014-03-27 16:09 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: davem, netdev
On Thu, 2014-03-27 at 16:34 +0100, Daniel Borkmann wrote:
> As in xmit path we merely update statistics and free the skb, we
> can mark the device with LLTX feature, so that upper layers can
> avoid taking the single txq lock on xmit. While at it, also add
> missing NETIF_F_SG.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> drivers/net/nlmon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: nlmon: flag nlmon devs with LLTX/SG
2014-03-27 15:34 [PATCH net-next] net: nlmon: flag nlmon devs with LLTX/SG Daniel Borkmann
2014-03-27 16:09 ` Eric Dumazet
@ 2014-03-28 20:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-03-28 20:50 UTC (permalink / raw)
To: dborkman; +Cc: netdev
From: Daniel Borkmann <dborkman@redhat.com>
Date: Thu, 27 Mar 2014 16:34:59 +0100
> As in xmit path we merely update statistics and free the skb, we
> can mark the device with LLTX feature, so that upper layers can
> avoid taking the single txq lock on xmit. While at it, also add
> missing NETIF_F_SG.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-28 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-27 15:34 [PATCH net-next] net: nlmon: flag nlmon devs with LLTX/SG Daniel Borkmann
2014-03-27 16:09 ` Eric Dumazet
2014-03-28 20:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).