From: David Miller <davem@davemloft.net>
To: vyasevic@redhat.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net] net: Account for all vlan headers in skb_mac_gso_segment
Date: Fri, 28 Mar 2014 17:10:50 -0400 (EDT) [thread overview]
Message-ID: <20140328.171050.472173056877978647.davem@davemloft.net> (raw)
In-Reply-To: <1395955578-16715-1-git-send-email-vyasevic@redhat.com>
From: Vlad Yasevich <vyasevic@redhat.com>
Date: Thu, 27 Mar 2014 17:26:18 -0400
> skb_network_protocol() already accounts for multiple vlan
> headers that may be present in the skb. However, skb_mac_gso_segment()
> doesn't know anything about it and assumes that skb->mac_len
> is set correctly to skip all mac headers. That may not
> always be the case. If we are simply forwarding the packet (via
> bridge or macvtap), all vlan headers may not be accounted for.
>
> A simple solution is to allow skb_network_protocol to return
> the vlan depth it has calculated. This way skb_mac_gso_segment
> will correctly skip all mac headers.
>
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> ---
> Since v1:
> - Removed conditionals and used dummy variables as suggested by
> Eric Dumazet.
Applied, thanks.
prev parent reply other threads:[~2014-03-28 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 21:26 [PATCH v2 net] net: Account for all vlan headers in skb_mac_gso_segment Vlad Yasevich
2014-03-27 22:21 ` Eric Dumazet
2014-03-28 1:05 ` Vlad Yasevich
2014-03-28 21:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328.171050.472173056877978647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).