From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Cc: makita.toshiaki@lab.ntt.co.jp
Subject: new leaks in bridging code.
Date: Sat, 29 Mar 2014 17:01:02 -0400 [thread overview]
Message-ID: <20140329210102.GA22516@redhat.com> (raw)
In-Reply-To: <533730f2396e8_1c4bb46874192e@209.249.196.67.mail>
yesterdays bridging changes introduced leaks in the exit paths..
** CID 1194948: Resource leak (RESOURCE_LEAK)
/net/bridge/br_vlan.c: 196 in br_allowed_ingress()
/net/bridge/br_vlan.c: 218 in br_allowed_ingress()
/net/bridge/br_vlan.c: 220 in br_allowed_ingress()
*** CID 1194948: Resource leak (RESOURCE_LEAK)
/net/bridge/br_vlan.c: 196 in br_allowed_ingress()
190
191 /* Frame had a tag with VID 0 or did not have a tag.
192 * See if pvid is set on this port. That tells us which
193 * vlan untagged or priority-tagged traffic belongs to.
194 */
195 if (pvid == VLAN_N_VID)
>>> CID 1194948: Resource leak (RESOURCE_LEAK)
>>> Returning without freeing "skb" leaks the storage that it points to.
196 return false;
197
198 /* PVID is set on this port. Any untagged or priority-tagged
199 * ingress frame is considered to belong to this vlan.
200 */
201 *vid = pvid;
/net/bridge/br_vlan.c: 218 in br_allowed_ingress()
212
213 return true;
214 }
215
216 /* Frame had a valid vlan tag. See if vlan is allowed */
217 if (test_bit(*vid, v->vlan_bitmap))
>>> CID 1194948: Resource leak (RESOURCE_LEAK)
>>> Returning without freeing "skb" leaks the storage that it points to.
218 return true;
219
220 return false;
221 }
222
223 /* Called under RCU. */
/net/bridge/br_vlan.c: 220 in br_allowed_ingress()
214 }
215
216 /* Frame had a valid vlan tag. See if vlan is allowed */
217 if (test_bit(*vid, v->vlan_bitmap))
218 return true;
219
>>> CID 1194948: Resource leak (RESOURCE_LEAK)
>>> Returning without freeing "skb" leaks the storage that it points to.
220 return false;
221 }
222
223 /* Called under RCU. */
224 bool br_allowed_egress(struct net_bridge *br,
225 const struct net_port_vlans *v,
next parent reply other threads:[~2014-03-29 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <533730f2396e8_1c4bb46874192e@209.249.196.67.mail>
2014-03-29 21:01 ` Dave Jones [this message]
2014-03-30 2:28 ` new leaks in bridging code Toshiaki Makita
2014-03-30 2:47 ` Dave Jones
2014-03-31 3:54 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329210102.GA22516@redhat.com \
--to=davej@redhat.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).