From: David Miller <davem@davemloft.net>
To: decot@googlers.com
Cc: jhs@mojatatu.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
edumazet@google.com, ebiederm@xmission.com,
chenweilong@huawei.com, jiri@resnulli.us, amirv@mellanox.com,
mwdalton@google.com, viro@ZenIV.linux.org.uk, tj@kernel.org
Subject: Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes
Date: Mon, 31 Mar 2014 16:25:19 -0400 (EDT) [thread overview]
Message-ID: <20140331.162519.2285405045402915587.davem@davemloft.net> (raw)
In-Reply-To: <2fd338e34d809af14353a03bc1edd0935f332faf.1396111568.git.decot@googlers.com>
From: David Decotigny <decot@googlers.com>
Date: Sat, 29 Mar 2014 09:48:35 -0700
> This allows to monitor carrier on/off transitions and detect link
> flapping issues:
> - new /sys/class/net/X/carrier_changes
> - new rtnetlink IFLA_CARRIER_CHANGES (getlink)
>
> Tested:
> - grep . /sys/class/net/*/carrier_changes
> + ip link set dev X down/up
> + plug/unplug cable
> - updated iproute2: prints IFLA_CARRIER_CHANGES
> - iproute2 20121211-2 (debian): unchanged behavior
>
> Signed-off-by: David Decotigny <decot@googlers.com>
Looks good, applied, thanks David.
prev parent reply other threads:[~2014-03-31 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1396111568.git.decot@googlers.com>
2014-03-29 16:48 ` [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes David Decotigny
2014-03-30 1:36 ` Stephen Hemminger
2014-03-30 1:50 ` Eric Dumazet
2014-03-30 15:18 ` David Decotigny
2014-03-31 16:49 ` Florian Fainelli
2014-03-31 20:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331.162519.2285405045402915587.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=chenweilong@huawei.com \
--cc=decot@googlers.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mwdalton@google.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).