From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: festevam@gmail.com, netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] ipv6: some ipv6 statistic counters failed to disable bh
Date: Mon, 31 Mar 2014 16:39:04 -0400 (EDT) [thread overview]
Message-ID: <20140331.163904.1733729527022532179.davem@davemloft.net> (raw)
In-Reply-To: <20140331181410.GC24150@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Mon, 31 Mar 2014 20:14:10 +0200
> After commit c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify
> processing to workqueue") some counters are now updated in process context
> and thus need to disable bh before doing so, otherwise deadlocks can
> happen on 32-bit archs. Fabio Estevam noticed this while while mounting
> a NFS volume on an ARM board.
>
> As a compensation for missing this I looked after the other *_STATS_BH
> and found three other calls which need updating:
>
> 1) icmp6_send: ip6_fragment -> icmpv6_send -> icmp6_send (error handling)
> 2) ip6_push_pending_frames: rawv6_sendmsg -> rawv6_push_pending_frames -> ...
> (only in case of icmp protocol with raw sockets in error handling)
> 3) ping6_v6_sendmsg (error handling)
>
> Fixes: c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify processing to workqueue")
> Reported-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
>
> I would propose this patch for -stable, too.
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-03-31 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 16:14 NFS does not work on linux-next 20140331 Fabio Estevam
2014-03-31 16:21 ` Hannes Frederic Sowa
2014-03-31 16:29 ` Eric Dumazet
2014-03-31 16:35 ` Fabio Estevam
2014-03-31 16:43 ` Hannes Frederic Sowa
2014-03-31 16:50 ` Fabio Estevam
2014-03-31 16:54 ` Hannes Frederic Sowa
2014-03-31 17:41 ` Eric Dumazet
2014-03-31 16:47 ` Eric Dumazet
2014-03-31 18:14 ` [PATCH net] ipv6: some ipv6 statistic counters failed to disable bh Hannes Frederic Sowa
2014-03-31 20:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331.163904.1733729527022532179.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=festevam@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).