From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] at86rf230: mask irq's before deregister device Date: Mon, 31 Mar 2014 16:43:34 -0400 (EDT) Message-ID: <20140331.164334.791905030722014681.davem@davemloft.net> References: <1396229211-9146-1-git-send-email-alex.aring@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com, linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org To: alex.aring@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:43069 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbaCaUnh (ORCPT ); Mon, 31 Mar 2014 16:43:37 -0400 In-Reply-To: <1396229211-9146-1-git-send-email-alex.aring@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Alexander Aring Date: Mon, 31 Mar 2014 03:26:51 +0200 > While transmit over a at86rf231 device and unloading the module I got: > > [ 29.643073] WARNING: CPU: 0 PID: 3 at kernel/workqueue.c:1335 __queue_work+0xb4/0x224() > [ 29.651457] Modules linked in: at86rf230(-) autofs4 > [ 29.656612] CPU: 0 PID: 3 Comm: ksoftirqd/0 Tainted: G W 3.14.0-rc6-01602-g902659e-dirty #294 > [ 29.666490] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 29.674628] [] (show_stack) from [] (warn_slowpath_common+0x60/0x80) > [ 29.683116] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x18/0x20) > [ 29.692329] [] (warn_slowpath_null) from [] (__queue_work+0xb4/0x224) > [ 29.700906] [] (__queue_work) from [] (queue_work_on+0x50/0x78) > [ 29.708944] [] (queue_work_on) from [] (mac802154_tx+0x1e4/0x240) > [ 29.717164] [] (mac802154_tx) from [] (dev_hard_start_xmit+0x2f0/0x43c) > [ 29.725926] [] (dev_hard_start_xmit) from [] (sch_direct_xmit+0x64/0x2a0) > [ 29.734867] [] (sch_direct_xmit) from [] (__qdisc_run+0x12c/0x18c) > [ 29.743169] [] (__qdisc_run) from [] (net_tx_action+0xe0/0x178) > [ 29.751205] [] (net_tx_action) from [] (__do_softirq+0x100/0x264) > [ 29.759420] [] (__do_softirq) from [] (run_ksoftirqd+0x24/0x4c) > [ 29.767453] [] (run_ksoftirqd) from [] (smpboot_thread_fn+0x128/0x13c) > [ 29.776121] [] (smpboot_thread_fn) from [] (kthread+0xd0/0xe4) > [ 29.784061] [] (kthread) from [] (ret_from_fork+0x14/0x2c) > [ 29.791628] ---[ end trace 3406ff24bd973834 ]--- > > The problem is there are still interrupts after deregister ieee802154 > device. This patch mask all interrupts in the at86rf2xx chips before > deregister the device. > > Signed-off-by: Alexander Aring Applied, thanks.