From: Richard Cochran <richardcochran@gmail.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <dborkman@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: ptp: oki-semi: fix build dependency
Date: Mon, 31 Mar 2014 20:55:38 +0200 [thread overview]
Message-ID: <20140331185538.GB7729@netboy> (raw)
In-Reply-To: <1396288941-23063-1-git-send-email-ast@plumgrid.com>
On Mon, Mar 31, 2014 at 11:02:21AM -0700, Alexei Starovoitov wrote:
> Richard,
> thank you for suggestion.
> oki-semi depends on ptp, so it's cleaner to move ptp_classify_raw there,
> instead of making it unconditionally available in net/core
> Daniel,
> timestamping has its own copy of PTP_FILTER, since timestamping
> doesn't depend on ptp and I didn't want to add circular dependency,
> since some of ptp pieces depend on timestamping, but not the others
We don't really need two copies. As long as you are refactoring this,
why not reduce it to just one filter?
Something like
#if defined(CONFIG_PTP_1588_CLOCK) || defined(CONFIG_NETWORK_PHY_TIMESTAMPING)
... code here ...
#endif
could go into filter.c or somewhere else in the stack.
Thanks,
Richard
next prev parent reply other threads:[~2014-03-31 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 18:02 [PATCH v2 net-next] net: ptp: oki-semi: fix build dependency Alexei Starovoitov
2014-03-31 18:55 ` Richard Cochran [this message]
2014-03-31 20:19 ` Alexei Starovoitov
2014-03-31 22:26 ` Daniel Borkmann
2014-04-01 14:27 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331185538.GB7729@netboy \
--to=richardcochran@gmail.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).