From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch 1/3] net: sxgbe: sxgbe_mdio_register() frees the bus Date: Tue, 01 Apr 2014 16:27:34 -0400 (EDT) Message-ID: <20140401.162734.504976144664134433.davem@davemloft.net> References: <20140401133844.GA11536@mwanda> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bh74.an@samsung.com, ks.giri@samsung.com, siva.kallam@samsung.com, vipul.pandya@samsung.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: dan.carpenter@oracle.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:55203 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbaDAU1g (ORCPT ); Tue, 1 Apr 2014 16:27:36 -0400 In-Reply-To: <20140401133844.GA11536@mwanda> Sender: netdev-owner@vger.kernel.org List-ID: From: Dan Carpenter Date: Tue, 1 Apr 2014 16:38:44 +0300 > "err" is always zero at this point so we always unregister and free the > mdio_bus before returning success. This seems like left over code and > I have deleted it. > > Fixes: 1edb9ca69e8a ('net: sxgbe: add basic framework for Samsung 10Gb ethernet driver') > Signed-off-by: Dan Carpenter Applied.