From: David Miller <davem@davemloft.net>
To: weiyang@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, yevgenyp@mellanox.com,
ogerlitz@mellanox.com, amirv@mellanox.com, bhelgaas@google.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] net/mlx4_core: match pci_device_id including dynids
Date: Tue, 01 Apr 2014 22:29:55 -0400 (EDT) [thread overview]
Message-ID: <20140401.222955.1322740724254746495.davem@davemloft.net> (raw)
In-Reply-To: <1396326961-20395-1-git-send-email-weiyang@linux.vnet.ibm.com>
From: Wei Yang <weiyang@linux.vnet.ibm.com>
Date: Tue, 1 Apr 2014 12:36:01 +0800
> Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
> pci_device_id.driver_data to __mlx4_init_one during reset".
>
> pci_match_id() just match the static pci_device_id, which may return NULL if
> someone binds the driver to a device manually using
> /sys/bus/pci/drivers/.../new_id.
>
> This patch match pci_device_id with pci_match_device() to cover both dynids
> and static id_table.
>
> Thanks to Bjorn finding this issue.
>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> CC: Amir Vadai <amirv@mellanox.com>
> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
> Acked-by: Amir Vadai <amirv@mellanox.com>
And ACK from the PCI folks would be greatly appreciated.
Thanks.
next prev parent reply other threads:[~2014-04-02 2:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 4:36 [PATCH] net/mlx4_core: match pci_device_id including dynids Wei Yang
2014-04-02 2:29 ` David Miller [this message]
2014-04-02 18:28 ` Bjorn Helgaas
2014-04-03 1:51 ` Wei Yang
2014-04-03 3:11 ` Bjorn Helgaas
2014-04-03 6:54 ` Wei Yang
2014-04-03 21:12 ` Bjorn Helgaas
2014-04-04 14:20 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401.222955.1322740724254746495.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=weiyang@linux.vnet.ibm.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).