From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>,
David Miller <davem@davemloft.net>,
or.gerlitz@gmail.com, Amir Vadai <amirv@mellanox.com>,
netdev <netdev@vger.kernel.org>,
yevgenyp@mellanox.com
Subject: Re: [PATCH net-next] net/mlx4_core: Handle null return by pci_match_id()
Date: Tue, 1 Apr 2014 11:14:41 +0800 [thread overview]
Message-ID: <20140401031441.GA9772@richard> (raw)
In-Reply-To: <CAErSpo4mjKB-nDDNb6BSMi1+BZ62jdvP_Rma2gc3DTF9-KkgMA@mail.gmail.com>
On Mon, Mar 31, 2014 at 09:12:04PM -0600, Bjorn Helgaas wrote:
>On Mon, Mar 31, 2014 at 7:41 PM, Wei Yang <weiyang@linux.vnet.ibm.com> wrote:
>> On Mon, Mar 31, 2014 at 04:32:40PM -0400, David Miller wrote:
>>>From: Wei Yang <weiyang@linux.vnet.ibm.com>
>>>Date: Mon, 31 Mar 2014 11:54:39 +0800
>>>
>>>> On Sun, Mar 30, 2014 at 09:08:06PM +0300, Or Gerlitz wrote:
>>>>>On Sun, Mar 30, 2014 at 6:26 PM, Amir Vadai <amirv@mellanox.com> wrote:
>>>>>> Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
>>>>>> pci_device_id.driver_data to __mlx4_init_one during reset".
>>>>>>
>>>>>> pci_match_id() might return NULL if someone binds the driver to a device
>>>>>> manually using /sys/bus/pci/drivers/.../new_id. Need to check 'id'
>>>>>> before using it.
>>>>>>
>>>>>> Thanks to Bjorn who raised the problem.
>>>>>
>>>>>Well, that commit was applied to net and is now present in Linus
>>>>>tree... so assuming it's too late for 3.14, need to queue this for
>>>>>-stable
>>>>>
>>>>>Or.
>>>>
>>>> Sorry for this bothering, hope this will not block someone.
>>>>
>>>> Here is my suggestion for fixing this, not sure this is a good way to export
>>>> pci_match_device() to modules. This is my current solution to this problem. If
>>>> you have any comments, please let me know.
>>>
>>>This needs to be ACK'd by the PCI maintainers, please make sure they see this.
>>
>> Yes, I think Bjorn, maintainers of PCI, is in the list.
>>
>> Bjorn,
>>
>> Do you have some concern on this implementation?
>> Or, you suggest me to send this to pci maillist too?
>
>I haven't looked at the patch yet, but yes, please do copy linux-pci as well.
Ok, I will send this one again to both net and pci mail list.
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2014-04-01 3:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 15:26 [PATCH net-next] net/mlx4_core: Handle null return by pci_match_id() Amir Vadai
2014-03-30 18:08 ` Or Gerlitz
2014-03-31 3:54 ` Wei Yang
2014-03-31 4:52 ` Or Gerlitz
2014-03-31 6:29 ` Amir Vadai
2014-03-31 7:01 ` Wei Yang
2014-03-31 20:32 ` David Miller
2014-04-01 1:41 ` Wei Yang
2014-04-01 3:12 ` Bjorn Helgaas
2014-04-01 3:14 ` Wei Yang [this message]
2014-03-31 3:12 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401031441.GA9772@richard \
--to=weiyang@linux.vnet.ibm.com \
--cc=amirv@mellanox.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).