From: Richard Cochran <richardcochran@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, ast@plumgrid.com, fengguang.wu@intel.com,
netdev@vger.kernel.org, Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH] net: ptp: move PTP classifier in its own file
Date: Tue, 1 Apr 2014 18:37:01 +0200 [thread overview]
Message-ID: <20140401163701.GA4369@netboy> (raw)
In-Reply-To: <1396362023-8704-1-git-send-email-dborkman@redhat.com>
On Tue, Apr 01, 2014 at 04:20:23PM +0200, Daniel Borkmann wrote:
> In the kernel tree under tools/net/ we have bpf_asm and bpf_dbg
> tools, so the commented program can simply be translated via
> `./bpf_asm -c prog` where prog is a file that contains the
> commented code. This makes it easily readable/verifiable and when
> there's a need to change something, jump offsets etc do not need
> to be replaced manually which can be very error prone. Instead,
> a newly translated version via bpf_asm can simply replace the old
> code. I have checked opcode diffs before/after and it's the very
> same filter.
I'll take your word for it.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2014-04-01 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 14:20 [PATCH] net: ptp: move PTP classifier in its own file Daniel Borkmann
2014-04-01 16:37 ` Richard Cochran [this message]
2014-04-01 20:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401163701.GA4369@netboy \
--to=richardcochran@gmail.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).