From: David Miller <davem@davemloft.net>
To: jwboyer@fedoraproject.org
Cc: mugunthanvnm@ti.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: cpts: Add includes for ETH_HLEN and VLAN_HLEN definitions
Date: Thu, 03 Apr 2014 12:32:19 -0400 (EDT) [thread overview]
Message-ID: <20140403.123219.186974875530426005.davem@davemloft.net> (raw)
In-Reply-To: <20140403160843.GD15134@hansolo.jdub.homelinux.org>
From: Josh Boyer <jwboyer@fedoraproject.org>
Date: Thu, 3 Apr 2014 12:08:43 -0400
> If CONFIG_TI_CPTS is enabled, the ti_cpsw driver will fail to build with:
>
> drivers/net/ethernet/ti/cpts.c: In function 'cpts_match':
> drivers/net/ethernet/ti/cpts.c:266:12: error: 'ETH_HLEN' undeclared (first use in this function)
> offset = ETH_HLEN + IPV4_HLEN(data) + UDP_HLEN;
> ^
> drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/ti/cpts.c:276:23: error: 'VLAN_HLEN' undeclared (first use in this function)
> offset = ETH_HLEN + VLAN_HLEN;
> ^
>
> Add includes of if_ether.h and if_vlan.h to bring in the appropriate defines.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
A patch for this was already submitted to netdev and applied to the 'net'
GIT tree earlier today.
next prev parent reply other threads:[~2014-04-03 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:08 [PATCH] net: cpts: Add includes for ETH_HLEN and VLAN_HLEN definitions Josh Boyer
2014-04-03 16:32 ` David Miller [this message]
2014-04-03 16:35 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403.123219.186974875530426005.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox