From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH] vxlan: using AF_PACKET socket to send multicast packet cause WARNING
Date: Thu, 03 Apr 2014 12:48:23 -0400 (EDT) [thread overview]
Message-ID: <20140403.124823.898955109709979033.davem@davemloft.net> (raw)
In-Reply-To: <CADvbK_ftDf_AsbEeF9EViBm68Co3bj1L-fR1-BDA0Uxn=1LPpA@mail.gmail.com>
From: lucien xin <lucien.xin@gmail.com>
Date: Thu, 3 Apr 2014 13:28:33 +0800
> On Wed, Apr 2, 2014 at 10:51 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>> That breaks local socket accounting for tunneled packets.
> It do break, I think it should break, becaue vlxan send UDP packets,
> it should be bound to UDP socket.
The issue is that we use sockets in two different contexts here:
1) For memory accounting, which is why we should hold onto the
original socket.
2) For IP transmit state, which is why we need to reference the
vxlan layer's ipv4/ipv6 socket.
Also, we've never marked the vxlan socket as being charged to
the SKB, there may be unwanted side effects of this.
Furthmore this will hurt performance, it will add two new
atomic operations per packet send over VXLAN devices.
prev parent reply other threads:[~2014-04-03 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 9:08 [PATCH] vxlan: using AF_PACKET socket to send multicast packet cause WARNING Xin Long
2014-04-01 20:10 ` David Miller
2014-04-02 5:31 ` lucien xin
2014-04-02 14:51 ` Stephen Hemminger
2014-04-03 5:28 ` lucien xin
2014-04-03 16:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403.124823.898955109709979033.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).