From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: bnx2x: include irq.h for irqreturn_t definitions Date: Thu, 03 Apr 2014 14:04:55 -0400 (EDT) Message-ID: <20140403.140455.585675998546647028.davem@davemloft.net> References: <20140402152158.GB20438@zod> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ariele@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: jwboyer@fedoraproject.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45905 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbaDCSDW (ORCPT ); Thu, 3 Apr 2014 14:03:22 -0400 In-Reply-To: <20140402152158.GB20438@zod> Sender: netdev-owner@vger.kernel.org List-ID: From: Josh Boyer Date: Wed, 2 Apr 2014 11:21:58 -0400 > The bnx2x driver fails to build on ARM with: > > In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:28:0: > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:243:1: error: unknown type name 'irqreturn_t' > irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance); > ^ > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:251:1: error: unknown type name 'irqreturn_t' > irqreturn_t bnx2x_interrupt(int irq, void *dev_instance); > ^ > > Nothing in bnx2x_link.c or bnx2x_cmn.h is explicitly including the irq > definitions, so we add an include of linux/irq.h to pick them up. > > Signed-off-by: Josh Boyer Applied.