* [PATCH] net: bnx2x: include irq.h for irqreturn_t definitions
@ 2014-04-02 15:21 Josh Boyer
2014-04-03 18:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2014-04-02 15:21 UTC (permalink / raw)
To: Ariel Elior; +Cc: netdev, linux-kernel
The bnx2x driver fails to build on ARM with:
In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:28:0:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:243:1: error: unknown type name 'irqreturn_t'
irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance);
^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:251:1: error: unknown type name 'irqreturn_t'
irqreturn_t bnx2x_interrupt(int irq, void *dev_instance);
^
Nothing in bnx2x_link.c or bnx2x_cmn.h is explicitly including the irq
definitions, so we add an include of linux/irq.h to pick them up.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
index a89a40f88c25..384025605948 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
@@ -21,6 +21,7 @@
#include <linux/pci.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
+#include <linux/irq.h>
#include "bnx2x.h"
#include "bnx2x_sriov.h"
--
1.8.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: bnx2x: include irq.h for irqreturn_t definitions
2014-04-02 15:21 [PATCH] net: bnx2x: include irq.h for irqreturn_t definitions Josh Boyer
@ 2014-04-03 18:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-04-03 18:04 UTC (permalink / raw)
To: jwboyer; +Cc: ariele, netdev, linux-kernel
From: Josh Boyer <jwboyer@fedoraproject.org>
Date: Wed, 2 Apr 2014 11:21:58 -0400
> The bnx2x driver fails to build on ARM with:
>
> In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:28:0:
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:243:1: error: unknown type name 'irqreturn_t'
> irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance);
> ^
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:251:1: error: unknown type name 'irqreturn_t'
> irqreturn_t bnx2x_interrupt(int irq, void *dev_instance);
> ^
>
> Nothing in bnx2x_link.c or bnx2x_cmn.h is explicitly including the irq
> definitions, so we add an include of linux/irq.h to pick them up.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-03 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 15:21 [PATCH] net: bnx2x: include irq.h for irqreturn_t definitions Josh Boyer
2014-04-03 18:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).