* [PATCH] net: enic: include irq.h for irqreturn_t definitions
@ 2014-04-02 15:24 Josh Boyer
2014-04-03 18:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2014-04-02 15:24 UTC (permalink / raw)
To: Christian Benvenuti, Sujith Sankar; +Cc: netdev, linux-kernel
The enic driver fails to build on ARM with:
In file included from drivers/net/ethernet/cisco/enic/enic_res.c:40:0:
drivers/net/ethernet/cisco/enic/enic.h:48:2: error: expected specifier-qualifier-list before 'irqreturn_t'
irqreturn_t (*isr)(int, void *);
^
Nothing in the driver is explicitly including the irq definitions, so we add
an include of linux/irq.h to pick them up.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
drivers/net/ethernet/cisco/enic/enic.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/cisco/enic/enic.h
index e9f7c656ddda..e35c8e0202ad 100644
--- a/drivers/net/ethernet/cisco/enic/enic.h
+++ b/drivers/net/ethernet/cisco/enic/enic.h
@@ -29,6 +29,7 @@
#include "vnic_stats.h"
#include "vnic_nic.h"
#include "vnic_rss.h"
+#include <linux/irq.h>
#define DRV_NAME "enic"
#define DRV_DESCRIPTION "Cisco VIC Ethernet NIC Driver"
--
1.8.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: enic: include irq.h for irqreturn_t definitions
2014-04-02 15:24 [PATCH] net: enic: include irq.h for irqreturn_t definitions Josh Boyer
@ 2014-04-03 18:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-04-03 18:05 UTC (permalink / raw)
To: jwboyer; +Cc: benve, ssujith, netdev, linux-kernel
From: Josh Boyer <jwboyer@gmail.com>
Date: Wed, 2 Apr 2014 11:24:00 -0400
> The enic driver fails to build on ARM with:
>
> In file included from drivers/net/ethernet/cisco/enic/enic_res.c:40:0:
> drivers/net/ethernet/cisco/enic/enic.h:48:2: error: expected specifier-qualifier-list before 'irqreturn_t'
> irqreturn_t (*isr)(int, void *);
> ^
>
> Nothing in the driver is explicitly including the irq definitions, so we add
> an include of linux/irq.h to pick them up.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-03 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 15:24 [PATCH] net: enic: include irq.h for irqreturn_t definitions Josh Boyer
2014-04-03 18:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).