* [PATCH] net: qlcnic: include irq.h for irq definitions
@ 2014-04-02 15:25 Josh Boyer
2014-04-03 18:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2014-04-02 15:25 UTC (permalink / raw)
To: Himanshu Madhani, Rajesh Borundia, Shahed Shaikh
Cc: linux-driver, netdev, linux-kernel
The qlcnic driver fails to build on ARM with errors like:
In file included from drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:36:0,
from drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:8:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h:585:1: error: unknown type name 'irqreturn_t'
irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *);
^
Nothing in the driver is explicitly including the irq definitions, so we
add an include of linux/irq.h to pick them up.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
index f19f81cde134..cbc897e6bb8f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
@@ -23,6 +23,7 @@
#include <linux/ethtool.h>
#include <linux/mii.h>
#include <linux/timer.h>
+#include <linux/irq.h>
#include <linux/vmalloc.h>
--
1.8.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: qlcnic: include irq.h for irq definitions
2014-04-02 15:25 [PATCH] net: qlcnic: include irq.h for irq definitions Josh Boyer
@ 2014-04-03 18:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-04-03 18:05 UTC (permalink / raw)
To: jwboyer
Cc: himanshu.madhani, rajesh.borundia, shahed.shaikh, linux-driver,
netdev, linux-kernel
From: Josh Boyer <jwboyer@fedoraproject.org>
Date: Wed, 2 Apr 2014 11:25:47 -0400
> The qlcnic driver fails to build on ARM with errors like:
>
> In file included from drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:36:0,
> from drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:8:
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h:585:1: error: unknown type name 'irqreturn_t'
> irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *);
> ^
>
> Nothing in the driver is explicitly including the irq definitions, so we
> add an include of linux/irq.h to pick them up.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Applied, thanks Josh.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-03 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 15:25 [PATCH] net: qlcnic: include irq.h for irq definitions Josh Boyer
2014-04-03 18:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).