Samsung sxgbe driver - Kconfig issue

Samsung sxgbe driver - Kconfig issue

[Valdis Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

commit 1edb9ca69e8a7988900fc0283e10550b5592164d
Author: Siva Reddy <siva.kallam@samsung.com>
Date:   Tue Mar 25 12:10:54 2014 -0700

    net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

    This patch adds support for Samsung 10Gb ethernet driver(sxgbe).


This commit added the following in the Kconfig file:

config NET_VENDOR_SAMSUNG
        bool "Samsung Ethernet device"
        default y
        ---help---
          This is the driver for the SXGBE 10G Ethernet IP block found on Samsung
          platforms.

Please redo this to match the style of other NET_VENDOR_FOO, and make clear
that it only selects a submenu.  For instance, drivers/net/ethernet/qlogic/Kconfig
says:

config NET_VENDOR_QLOGIC
        bool "QLogic devices"
        default y
        depends on PCI
        ---help---
          If you have a network (Ethernet) card belonging to this class, say Y
          and read the Ethernet-HOWTO, available from
          <http://www.tldp.org/docs.html#howto>.

          Note that the answer to this question doesn't directly affect the
          kernel: saying N will just cause the configurator to skip all
          the questions about QLogic cards. If you say Y, you will be asked for
          your specific card in the following questions.

if NET_VENDOR_QLOGIC




[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

[PATCH net-next 1/1] sxgbe: use common NET_VENDOR_FOO style.

[Francois Romieu]

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---

 Valdis, is it what you had in mind ?

 drivers/net/ethernet/samsung/Kconfig       | 24 ++++++++++++++++++++----
 drivers/net/ethernet/samsung/sxgbe/Kconfig |  9 ---------
 2 files changed, 20 insertions(+), 13 deletions(-)
 delete mode 100644 drivers/net/ethernet/samsung/sxgbe/Kconfig

diff --git a/drivers/net/ethernet/samsung/Kconfig b/drivers/net/ethernet/samsung/Kconfig
index 7902341..2360d81 100644
--- a/drivers/net/ethernet/samsung/Kconfig
+++ b/drivers/net/ethernet/samsung/Kconfig
@@ -3,14 +3,30 @@
 #
 
 config NET_VENDOR_SAMSUNG
-	bool "Samsung Ethernet device"
+	bool "Samsung Ethernet devices"
 	default y
 	---help---
-	  This is the driver for the SXGBE 10G Ethernet IP block found on Samsung
-	  platforms.
+	  If you have a network (Ethernet) chipset belonging to this class,
+	  say Y.
+
+	  Note that the answer to this question does not directly affect
+	  the kernel: saying N will just case the configurator to skip all
+	  the questions about Samsung chipsets. If you say Y, you will be asked
+	  for your specific chipset/driver in the following questions.
 
 if NET_VENDOR_SAMSUNG
 
-source "drivers/net/ethernet/samsung/sxgbe/Kconfig"
+config SXGBE_ETH
+	tristate "Samsung 10G/2.5G/1G SXGBE Ethernet driver"
+	depends on HAS_IOMEM && HAS_DMA
+	select PHYLIB
+	select CRC32
+	select PTP_1588_CLOCK
+	---help---
+	  This is the driver for the SXGBE 10G Ethernet IP block found on
+	  Samsung platforms.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called samsung-sxgbe.
 
 endif # NET_VENDOR_SAMSUNG
diff --git a/drivers/net/ethernet/samsung/sxgbe/Kconfig b/drivers/net/ethernet/samsung/sxgbe/Kconfig
deleted file mode 100644
index d79288c..0000000
--- a/drivers/net/ethernet/samsung/sxgbe/Kconfig
+++ /dev/null
@@ -1,9 +0,0 @@
-config SXGBE_ETH
-	tristate "Samsung 10G/2.5G/1G SXGBE Ethernet driver"
-	depends on HAS_IOMEM && HAS_DMA
-	select PHYLIB
-	select CRC32
-	select PTP_1588_CLOCK
-	---help---
-	  This is the driver for the SXGBE 10G Ethernet IP block found on Samsung
-	  platforms.
-- 
1.9.0

Re: [PATCH net-next 1/1] sxgbe: use common NET_VENDOR_FOO style.

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 2459 bytes --]

On Thu, 03 Apr 2014 01:13:03 +0200, Francois Romieu said:
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
>
>  Valdis, is it what you had in mind ?

Works for me.  That brings it in line with other network drivers, feel free
to stick this on:

Acked-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

>  drivers/net/ethernet/samsung/Kconfig       | 24 ++++++++++++++++++++----
>  drivers/net/ethernet/samsung/sxgbe/Kconfig |  9 ---------
>  2 files changed, 20 insertions(+), 13 deletions(-)
>  delete mode 100644 drivers/net/ethernet/samsung/sxgbe/Kconfig
>
> diff --git a/drivers/net/ethernet/samsung/Kconfig b/drivers/net/ethernet/sams
ung/Kconfig
> index 7902341..2360d81 100644
> --- a/drivers/net/ethernet/samsung/Kconfig
> +++ b/drivers/net/ethernet/samsung/Kconfig
> @@ -3,14 +3,30 @@
>  #
>
>  config NET_VENDOR_SAMSUNG
> -	bool "Samsung Ethernet device"
> +	bool "Samsung Ethernet devices"
>  	default y
>  	---help---
> -	  This is the driver for the SXGBE 10G Ethernet IP block found on Samsu
ng
> -	  platforms.
> +	  If you have a network (Ethernet) chipset belonging to this class,
> +	  say Y.
> +
> +	  Note that the answer to this question does not directly affect
> +	  the kernel: saying N will just case the configurator to skip all
> +	  the questions about Samsung chipsets. If you say Y, you will be asked
> +	  for your specific chipset/driver in the following questions.
>
>  if NET_VENDOR_SAMSUNG
>
> -source "drivers/net/ethernet/samsung/sxgbe/Kconfig"
> +config SXGBE_ETH
> +	tristate "Samsung 10G/2.5G/1G SXGBE Ethernet driver"
> +	depends on HAS_IOMEM && HAS_DMA
> +	select PHYLIB
> +	select CRC32
> +	select PTP_1588_CLOCK
> +	---help---
> +	  This is the driver for the SXGBE 10G Ethernet IP block found on
> +	  Samsung platforms.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called samsung-sxgbe.
>
>  endif # NET_VENDOR_SAMSUNG
> diff --git a/drivers/net/ethernet/samsung/sxgbe/Kconfig b/drivers/net/etherne
t/samsung/sxgbe/Kconfig
> deleted file mode 100644
> index d79288c..0000000
> --- a/drivers/net/ethernet/samsung/sxgbe/Kconfig
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -config SXGBE_ETH
> -	tristate "Samsung 10G/2.5G/1G SXGBE Ethernet driver"
> -	depends on HAS_IOMEM && HAS_DMA
> -	select PHYLIB
> -	select CRC32
> -	select PTP_1588_CLOCK
> -	---help---
> -	  This is the driver for the SXGBE 10G Ethernet IP block found on Samsu
ng
> -	  platforms.
> --
> 1.9.0
>



[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

Re: [PATCH net-next 1/1] sxgbe: use common NET_VENDOR_FOO style.

[David Miller]

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 3 Apr 2014 01:13:03 +0200

> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Applied.